Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIE installable with Composer? #136

Open
asgrim opened this issue Nov 25, 2024 · 2 comments
Open

PIE installable with Composer? #136

asgrim opened this issue Nov 25, 2024 · 2 comments
Labels
maintainer feedback needed Needs details or feedback to be added by maintainers question Further information is requested

Comments

@asgrim
Copy link
Collaborator

asgrim commented Nov 25, 2024

Split from: #98 (comment)

Should PIE be installable with Composer?

$ composer global require php/pie

Points to note:

  • currently php/pie is the namespace; I believe this is a protected namespace on Packagist, so I would need to discuss with Packagist team about submitting this
  • in theory, this allows people to composer require php/pie (per project) which doesn't make any sense to do

Currently the only supported distribution mechanism is downloading the PHAR from the https://github.com/php/pie/releases page. Other distribution mechanisms should be carefully evaluated on a case-by-case basis.

@asgrim asgrim added question Further information is requested maintainer feedback needed Needs details or feedback to be added by maintainers labels Nov 25, 2024
@alexandre-daubois
Copy link
Contributor

I think it would be really nice. This way, if one day Pie allows to read from composer.json and install extensions listed in the file, we could even imagine having a postscript that then triggers Pie and install extensions after the packages. Just thinking out loud.

It would be so convenient to arrive on a project, and do compose install && vendor/bin/pie install ... because Composer installer Pie.

this allows people to composer require php/pie (per project) which doesn't make any sense to do

On the different projects I worked on, it's quite often that devs doesn't install Composer globally. I can understand that, some people like to have their projects a bit siloed without having to install tools globally on their system. In my opinion, having the choice is a good thing.

@macintoshplus
Copy link

IMO pie must be executed before the composer because the composer checks if all extension is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer feedback needed Needs details or feedback to be added by maintainers question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants