Merge pull request #94 from TimWolla/configure-flag-quoting

Remove `escapeshellarg()` quoting for configure flags

Author: asgrim

src/Command/CommandHelper.php

@@ -22,7 +22,6 @@
 use Webmozart\Assert\Assert;
 
 use function array_key_exists;
-use function escapeshellarg;
 use function is_array;
 use function is_string;
 use function reset;
@@ -225,7 +224,7 @@ public static function processConfigureOptionsFromInput(Package $package, InputI
 
             if ($configureOption->needsValue) {
                 if (is_string($value) && $value !== '') {
-                    $configureOptionsValues[] = '--' . $configureOption->name . '=' . escapeshellarg($value);
+                    $configureOptionsValues[] = '--' . $configureOption->name . '=' . $value;
                 }
 
                 continue;

test/behaviour/CliContext.php

@@ -103,7 +103,7 @@ public function theExtensionShouldHaveBeenBuiltWithOptions(): void
         }
 
         Assert::contains($this->output, 'phpize complete.');
-        Assert::contains($this->output, 'Configure complete with options: --with-hello-name=\'sup\'');
+        Assert::contains($this->output, 'Configure complete with options: --with-hello-name=sup');
         Assert::contains($this->output, 'Build complete:');
     }
 

test/unit/Command/CommandHelperTest.php

@@ -29,7 +29,6 @@
 
 use function array_combine;
 use function array_map;
-use function escapeshellarg;
 
 #[CoversClass(CommandHelper::class)]
 final class CommandHelperTest extends TestCase
@@ -174,7 +173,7 @@ public function testProcessingConfigureOptionsFromInput(): void
 
         self::assertSame(
             [
-                '--with-stuff=' . escapeshellarg('lolz'),
+                '--with-stuff=lolz',
                 '--enable-thing',
             ],
             $options,