Do not limit make command timeout

Author: asgrim

src/Building/UnixBuild.php

@@ -20,7 +20,7 @@ final class UnixBuild implements Build
 {
     private const PHPIZE_TIMEOUT_SECS    = 60; // 1 minute
     private const CONFIGURE_TIMEOUT_SECS = 120; // 2 minutes
-    private const MAKE_TIMEOUT_SECS      = 600; // 10 minutes
+    private const MAKE_TIMEOUT_SECS      = null; // unlimited
 
     /** {@inheritDoc} */
     public function __invoke(
@@ -101,7 +101,7 @@ private function make(TargetPlatform $targetPlatform, DownloadedPackage $downloa
             $output->writeln('Running make without parallelization - try providing -jN to PIE where N is the number of cores you have.');
         } else {
             $makeCommand[] = '--jobs';
-            $makeCommand[] = $targetPlatform->makeParallelJobs;
+            $makeCommand[] = (string) $targetPlatform->makeParallelJobs;
         }
 
         return Process::run(

src/Platform/TargetPlatform.php

@@ -5,8 +5,8 @@
 namespace Php\Pie\Platform;
 
 use Php\Pie\Platform\TargetPhp\PhpBinaryPath;
-
 use Php\Pie\Util\NumberOfCores;
+
 use function array_key_exists;
 use function curl_version;
 use function explode;

src/Util/NumberOfCores.php

@@ -6,6 +6,9 @@
 
 use Symfony\Component\Process\Process;
 
+use function is_numeric;
+use function trim;
+
 final class NumberOfCores
 {
     /** @psalm-suppress UnusedConstructor */

test/integration/Building/UnixBuildTest.php

@@ -50,7 +50,7 @@ public function testUnixBuildCanBuildExtension(): void
         $unixBuilder = new UnixBuild();
         $unixBuilder->__invoke(
             $downloadedPackage,
-            TargetPlatform::fromPhpBinaryPath(PhpBinaryPath::fromCurrentProcess()),
+            TargetPlatform::fromPhpBinaryPath(PhpBinaryPath::fromCurrentProcess(), null),
             ['--enable-pie_test_ext'],
             $output,
         );

test/integration/DependencyResolver/ResolveDependencyWithComposerTest.php

@@ -69,7 +69,7 @@ public function testDependenciesAreResolvedToExpectedVersions(
         $resolve   = $container->get(DependencyResolver::class);
 
         $package = $resolve->__invoke(
-            TargetPlatform::fromPhpBinaryPath(PhpBinaryPath::fromCurrentProcess()),
+            TargetPlatform::fromPhpBinaryPath(PhpBinaryPath::fromCurrentProcess(), null),
             'asgrim/example-pie-extension',
             $requestedVersion,
         );

test/integration/Installing/UnixInstallTest.php

@@ -75,7 +75,7 @@ public function testUnixInstallCanInstallExtension(string $phpConfig): void
         }
 
         $output         = new BufferedOutput();
-        $targetPlatform = TargetPlatform::fromPhpBinaryPath(PhpBinaryPath::fromPhpConfigExecutable($phpConfig));
+        $targetPlatform = TargetPlatform::fromPhpBinaryPath(PhpBinaryPath::fromPhpConfigExecutable($phpConfig), null);
         $extensionPath  = $targetPlatform->phpBinaryPath->extensionPath();
 
         $downloadedPackage = DownloadedPackage::fromPackageAndExtractedPath(

test/integration/Installing/WindowsInstallTest.php

@@ -65,6 +65,7 @@ public function testWindowsInstallCanInstallExtension(): void
             PhpBinaryPath::fromCurrentProcess(),
             Architecture::x86_64,
             ThreadSafetyMode::ThreadSafe,
+            1,
             WindowsCompiler::VS16,
         );
         $phpPath           = dirname($targetPlatform->phpBinaryPath->phpBinaryPath);

test/unit/Command/CommandHelperTest.php

@@ -92,7 +92,7 @@ public function testInvalidRequestedNameAndVersionPairThrowsExceptionWhenNoPacka
     public function testDownloadPackage(): void
     {
         $dependencyResolver          = $this->createMock(DependencyResolver::class);
-        $targetPlatform              = TargetPlatform::fromPhpBinaryPath(PhpBinaryPath::fromCurrentProcess());
+        $targetPlatform              = TargetPlatform::fromPhpBinaryPath(PhpBinaryPath::fromCurrentProcess(), null);
         $requestedNameAndVersionPair = ['name' => 'php/test-pie-ext', 'version' => '^1.2'];
         $downloadAndExtract          = $this->createMock(DownloadAndExtract::class);
         $output                      = $this->createMock(OutputInterface::class);

test/unit/DependencyResolver/ResolveDependencyWithComposerTest.php

@@ -57,6 +57,7 @@ public function testPackageThatCanBeResolved(): void
             $phpBinaryPath,
             Architecture::x86_64,
             ThreadSafetyMode::ThreadSafe,
+            1,
             null,
         );
 
@@ -97,6 +98,7 @@ public function testPackageThatCannotBeResolvedThrowsException(array $platformOv
             $phpBinaryPath,
             Architecture::x86_64,
             ThreadSafetyMode::ThreadSafe,
+            1,
             null,
         );
 
@@ -139,6 +141,7 @@ public function testZtsOnlyPackageCannotBeInstalledOnNtsSystem(): void
             $phpBinaryPath,
             Architecture::x86_64,
             ThreadSafetyMode::NonThreadSafe,
+            1,
             null,
         );
 
@@ -181,6 +184,7 @@ public function testNtsOnlyPackageCannotBeInstalledOnZtsSystem(): void
             $phpBinaryPath,
             Architecture::x86_64,
             ThreadSafetyMode::ThreadSafe,
+            1,
             null,
         );
 

test/unit/Downloading/Exception/CouldNotFindReleaseAssetTest.php

@@ -67,6 +67,7 @@ public function testForMissingWindowsCompiler(): void
             $phpBinary,
             Architecture::x86,
             ThreadSafetyMode::NonThreadSafe,
+            1,
             null,
         ));
 

test/unit/Downloading/GithubPackageReleaseAssetsTest.php

@@ -41,6 +41,7 @@ public function testUrlIsReturnedWhenFindingWindowsDownloadUrl(): void
             $phpBinaryPath,
             Architecture::x86,
             ThreadSafetyMode::ThreadSafe,
+            1,
             WindowsCompiler::VC14,
         );
 
@@ -97,6 +98,7 @@ public function testUrlIsReturnedWhenFindingWindowsDownloadUrlWithCompilerAndThr
             $phpBinaryPath,
             Architecture::x86,
             ThreadSafetyMode::ThreadSafe,
+            1,
             WindowsCompiler::VC14,
         );
 
@@ -148,6 +150,7 @@ public function testFindWindowsDownloadUrlForPackageThrowsExceptionWhenAssetNotF
             PhpBinaryPath::fromCurrentProcess(),
             Architecture::x86,
             ThreadSafetyMode::ThreadSafe,
+            1,
             WindowsCompiler::VC14,
         );
 

test/unit/Downloading/UnixDownloadAndExtractTest.php

@@ -32,6 +32,7 @@ public function testInvoke(): void
             PhpBinaryPath::fromCurrentProcess(),
             Architecture::x86,
             ThreadSafetyMode::NonThreadSafe,
+            1,
             null,
         );
 

test/unit/Downloading/WindowsDownloadAndExtractTest.php

@@ -37,6 +37,7 @@ public function testInvoke(): void
             PhpBinaryPath::fromCurrentProcess(),
             Architecture::x86,
             ThreadSafetyMode::ThreadSafe,
+            1,
             WindowsCompiler::VC14,
         );
 

test/unit/Installing/InstallNotification/SendInstallNotificationUsingGuzzleTest.php

@@ -53,6 +53,7 @@ public function setUp(): void
             $phpBinaryPath,
             Architecture::x86,
             ThreadSafetyMode::ThreadSafe,
+            1,
             WindowsCompiler::VC14,
         );
     }

test/unit/Platform/TargetPlatformTest.php

@@ -50,7 +50,7 @@ public function testWindowsPlatformFromPhpInfo(): void
 PHP Extension Build => API20230831,TS,VS16
 TEXT);
 
-        $platform = TargetPlatform::fromPhpBinaryPath($phpBinaryPath);
+        $platform = TargetPlatform::fromPhpBinaryPath($phpBinaryPath, null);
 
         self::assertSame(OperatingSystem::Windows, $platform->operatingSystem);
         self::assertSame(WindowsCompiler::VS16, $platform->windowsCompiler);
@@ -91,7 +91,7 @@ public function testLinuxPlatform(): void
 Thread Safety => disabled
 TEXT);
 
-        $platform = TargetPlatform::fromPhpBinaryPath($phpBinaryPath);
+        $platform = TargetPlatform::fromPhpBinaryPath($phpBinaryPath, null);
 
         self::assertSame(OperatingSystem::NonWindows, $platform->operatingSystem);
         self::assertSame(null, $platform->windowsCompiler);

test/unit/Platform/WindowsExtensionAssetNameTest.php

@@ -33,6 +33,7 @@ public function setUp(): void
             PhpBinaryPath::fromCurrentProcess(),
             Architecture::x86_64,
             ThreadSafetyMode::ThreadSafe,
+            1,
             WindowsCompiler::VC14,
         );