Define type for MinimalHelperSet to eliminate some tests

Author: asgrim

src/ComposerIntegration/MinimalHelperSet.php

@@ -8,14 +8,16 @@
 use Symfony\Component\Console\Helper\QuestionHelper;
 use Webmozart\Assert\Assert;
 
+/** @internal This is not public API for PIE, so should not be depended upon unless you accept the risk of BC breaks */
 class MinimalHelperSet extends HelperSet
 {
-    public function __construct(array $helpers = [])
+    /** @param array{question: QuestionHelper} $helpers */
+    public function __construct(array $helpers)
     {
         Assert::isInstanceOf(
             $helpers['question'] ?? null,
             QuestionHelper::class,
-            'The question option must be an instance of %2$s, got %s'
+            'The question option must be an instance of %2$s, got %s',
         );
 
         parent::__construct($helpers);

src/Container.php

@@ -25,7 +25,6 @@
 use Php\Pie\Installing\UnixInstall;
 use Php\Pie\Installing\WindowsInstall;
 use Psr\Container\ContainerInterface;
-use Symfony\Component\Console\Helper\HelperSet;
 use Symfony\Component\Console\Helper\QuestionHelper;
 use Symfony\Component\Console\Input\ArgvInput;
 use Symfony\Component\Console\Input\InputInterface;

test/unit/ComposerIntegration/MinimalHelperSetTest.php

@@ -7,7 +7,6 @@
 use Php\Pie\ComposerIntegration\MinimalHelperSet;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\TestCase;
-use stdClass;
 use Symfony\Component\Console\Helper\QuestionHelper;
 
 #[CoversClass(MinimalHelperSet::class)]
@@ -18,16 +17,4 @@ public function testHappyPath(): void
         $this->expectNotToPerformAssertions();
         new MinimalHelperSet(['question' => $this->createMock(QuestionHelper::class)]);
     }
-
-    public function testQuestionOptionIsMissing(): void
-    {
-        $this->expectExceptionMessage('The question option must be an instance of Symfony\Component\Console\Helper\QuestionHelper, got NULL');
-        new MinimalHelperSet([]);
-    }
-
-    public function testQuestionOptionIsNotAQuestionHelper(): void
-    {
-        $this->expectExceptionMessage('The question option must be an instance of Symfony\Component\Console\Helper\QuestionHelper, got stdClass');
-        new MinimalHelperSet(['question' => new stdClass()]);
-    }
 }