Ensure package resolved is a php-ext or php-ext-zend

Author: asgrim

src/DependencyResolver/Package.php

@@ -9,6 +9,9 @@
 /** @internal This is not public API for PIE, so should not be depended upon unless you accept the risk of BC breaks */
 final class Package
 {
+    public const TYPE_PHP_MODULE     = 'php-ext';
+    public const TYPE_ZEND_EXTENSION = 'php-ext-zend';
+
     private function __construct(
         public readonly string $name,
         public readonly string $version,

src/DependencyResolver/ResolveDependencyWithComposer.php

@@ -10,6 +10,8 @@
 use Php\Pie\TargetPhp\PhpBinaryPath;
 use Php\Pie\TargetPhp\ResolveTargetPhpToPlatformRepository;
 
+use function in_array;
+
 /** @internal This is not public API for PIE, so should not be depended upon unless you accept the risk of BC breaks */
 final class ResolveDependencyWithComposer implements DependencyResolver
 {
@@ -27,12 +29,15 @@ public function __invoke(PhpBinaryPath $phpBinaryPath, string $packageName, stri
         ))
             ->findBestCandidate($packageName, $requestedVersion);
 
-        // @todo check it is a `php-ext` or `php-ext-zend`
-
         if (! $package instanceof CompletePackageInterface) {
             throw UnableToResolveRequirement::fromRequirement($packageName, $requestedVersion);
         }
 
+        $type = $package->getType();
+        if (! in_array($type, [Package::TYPE_PHP_MODULE, Package::TYPE_ZEND_EXTENSION])) {
+            throw UnableToResolveRequirement::toPhpOrZendExtension($package, $packageName, $requestedVersion);
+        }
+
         return Package::fromComposerCompletePackage($package);
     }
 }

src/DependencyResolver/UnableToResolveRequirement.php

@@ -4,6 +4,7 @@
 
 namespace Php\Pie\DependencyResolver;
 
+use Composer\Package\PackageInterface;
 use RuntimeException;
 
 use function sprintf;
@@ -18,4 +19,14 @@ public static function fromRequirement(string $requiredPackageName, string|null
             $requiredVersion !== null ? sprintf(' for version %s.', $requiredVersion) : '.',
         ));
     }
+
+    public static function toPhpOrZendExtension(PackageInterface $locatedComposerPackage, string $requiredPackageName, string|null $requiredVersion): self
+    {
+        return new self(sprintf(
+            'Package %s was not of type php-ext or php-ext-zend (requested %s%s)',
+            $locatedComposerPackage->getName(),
+            $requiredPackageName,
+            $requiredVersion !== null ? sprintf(' for version %s.', $requiredVersion) : '.',
+        ));
+    }
 }

test/unit/DependencyResolver/ResolveDependencyWithComposerTest.php

@@ -35,16 +35,17 @@ public function setUp(): void
     public function testPackageThatCanBeResolved(): void
     {
         $phpBinaryPath = $this->createMock(PhpBinaryPath::class);
-        $phpBinaryPath->expects(self::once())
+        $phpBinaryPath->expects(self::any())
             ->method('version')
-            ->willReturn('8.2.0');
+            ->willReturn('8.3.0');
 
         $package = (new ResolveDependencyWithComposer(
             $this->repositorySet,
             $this->resolveTargetPhpToPlatformRepository,
-        ))($phpBinaryPath, 'phpunit/phpunit', '^11.0');
+        ))($phpBinaryPath, 'asgrim/example-pie-extension', '1.0.0');
 
-        self::assertSame('phpunit/phpunit', $package->name);
+        self::assertSame('asgrim/example-pie-extension', $package->name);
+        self::assertSame('1.0.0', $package->version);
     }
 
     /**
@@ -55,8 +56,9 @@ public function testPackageThatCanBeResolved(): void
     public static function unresolvableDependencies(): array
     {
         return [
-            'phpVersionTooOld' => [['php' => '8.1.0'], 'phpunit/phpunit', '^11.0'],
-            'phpVersionTooNew' => [['php' => '8.3.0'], 'roave/signature', '1.4.*'],
+            'phpVersionTooOld' => [['php' => '8.1.0'], 'asgrim/example-pie-extension', '1.0.0'],
+            'phpVersionTooNew' => [['php' => '8.4.0'], 'asgrim/example-pie-extension', '1.0.0'],
+            'notAPhpExtension' => [['php' => '8.3.0'], 'ramsey/uuid', '^4.7'],
         ];
     }