Failing to build PHP 8.4.5 from source

[abcbarryn]

Description

make: *** No rule to make target 'php-8.4.5/ext/date/lib/parse_date.c', needed by 'ext/date/lib/parse_date.lo'. Stop.

I am attempting to compile https://secure.php.net/distributions/php-8.4.5.tar.xz

If I manually create parse_date.c by running
re2c parse_date.re >parse_date.c
the compilation continues, but shouldn't the Makefile be doing this? Also, other .re files seem not to be generating their .c files. I did not have this issue when building PHP 8.2.

PHP Version

PHP 8.4.5

Operating System

SuSE Linux

[devnexen]

Hi, can you describe all the steps you went through once you extracted the archive ?

[abcbarryn]

I think I found the bad assumption in my .spec file...

# get parsers regenerated
for parser in $(find -type f -name "*.re");do
    rm -v ${parser%.*}.c
done

But really shouldn't the Makefile regenerate them? It used to for version 8.2.

[abcbarryn]

PS: I manually rebuilt the .c files from the .re files for now by adding this script:

    for refile in `find . -type f -name '*.re' -print`
    do
        dir=`dirname "$refile"`
        basefile=`basename "$refile" .re`
        if [ ! -e "$dir/$basefile.c" ]
        then
            re2c "$refile" >"$dir/$basefile.c" || re2c -c "$refile" >"$dir/$basefile.c"
        fi
    done

The Makefile should do this though, it used to on 8.2. If the .re files are not the source files anymore and it is intended to use and update the .c files directly then the .re files should probably be removed so someone else doesn't try to use them.

[devnexen]

Are you doing a custom build workflow ? e.g. not using buildconf

[abcbarryn]

I am using the spec file I used to build 8.2, but I changed the version to 8.4.5 so it loads the 8.4.5 tar source file. Like I said, it removes the .c files generated by re2c expecting Make to rebuild them. In 8.2, it does, in 8.4.5, it does not.

[iluuu1994]

ext-date commits the generated parser file. Hence, there shouldn't be a reason for you to regenerate it. Your spec file seems to be too eager. Changes to the ext/date/lib/parse_date.re file would need to be upstreamed to https://github.com/derickr/timelib anyway, so it shouldn't be modified directly.

Edit: Just to expand on this:

Like I said, it removes the .c files generated by re2c expecting Make to rebuild them. In 8.2, it does, in 8.4.5, it does not.

That's confusing, because I don't think the build process has really changed in that regard.