Skip to content

Commit fd44258

Browse files
committed
Rename "Callable\ParameterXxx" to "Callable\CallableParameterXxx"
1 parent bf35434 commit fd44258

File tree

7 files changed

+42
-23
lines changed

7 files changed

+42
-23
lines changed

resources/grammar/callable.pp2

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ CallableType -> {
88

99
$parameters = isset($children[0]) && $children[0] instanceof Node\Stmt\Callable\ParametersListNode
1010
? \array_shift($children)
11-
: new Node\Stmt\Callable\ParametersListNode();
11+
: new Node\Stmt\Callable\CallableParametersListNode();
1212

1313
return new Node\Stmt\CallableTypeNode(
1414
name: $name,
@@ -24,7 +24,7 @@ CallableType -> {
2424
;
2525

2626
CallableParameters -> {
27-
return new Node\Stmt\Callable\ParametersListNode($children);
27+
return new Node\Stmt\Callable\CallableParametersListNode($children);
2828
}
2929
: CallableParameter() (::T_COMMA:: CallableParameter())* ::T_COMMA::?
3030
;
@@ -91,7 +91,7 @@ VariadicCallableParameter -> {
9191
;
9292

9393
OutputCallableParameter -> {
94-
$argument = new Node\Stmt\Callable\ParameterNode($children[0]);
94+
$argument = new Node\Stmt\Callable\CallableParameterNode($children[0]);
9595

9696
if (\count($children) !== 1) {
9797
$argument->output = true;
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace TypeLang\Parser\Node\Stmt\Callable;
6+
7+
class CallableParameterNode extends ParameterNode {}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace TypeLang\Parser\Node\Stmt\Callable;
6+
7+
class CallableParametersListNode extends ParametersListNode {}

src/Node/Stmt/Callable/ParameterNode.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@
99
use TypeLang\Parser\Node\Stmt\Attribute\AttributeGroupsListNode;
1010
use TypeLang\Parser\Node\Stmt\TypeStatement;
1111

12-
final class ParameterNode extends Node implements \Stringable
12+
/**
13+
* @deprecated Since 1.3, please use {@see CallableParameterNode} instead.
14+
*/
15+
class ParameterNode extends Node implements \Stringable
1316
{
1417
public function __construct(
1518
public ?TypeStatement $type = null,

src/Node/Stmt/Callable/ParametersListNode.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,7 @@
88

99
/**
1010
* @template-extends NodeList<ParameterNode>
11+
*
12+
* @deprecated Since 1.3, please use {@see CallableParametersListNode} instead.
1113
*/
1214
class ParametersListNode extends NodeList {}

tests/Unit/Types/PhpStanTypesTest.php

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -433,12 +433,12 @@ public static function typesDataProvider(): iterable
433433
Stmt\CallableTypeNode
434434
Name(callable)
435435
Identifier(callable)
436-
Stmt\Callable\ParametersListNode
437-
Stmt\Callable\ParameterNode(simple)
436+
Stmt\Callable\CallableParametersListNode
437+
Stmt\Callable\CallableParameterNode(simple)
438438
Stmt\NamedTypeNode
439439
Name(int)
440440
Identifier(int)
441-
Stmt\Callable\ParameterNode(simple)
441+
Stmt\Callable\CallableParameterNode(simple)
442442
Stmt\NamedTypeNode
443443
Name(int)
444444
Identifier(int)
@@ -450,12 +450,12 @@ public static function typesDataProvider(): iterable
450450
Stmt\CallableTypeNode
451451
Name(callable)
452452
Identifier(callable)
453-
Stmt\Callable\ParametersListNode
454-
Stmt\Callable\ParameterNode(simple)
453+
Stmt\Callable\CallableParametersListNode
454+
Stmt\Callable\CallableParameterNode(simple)
455455
Stmt\NamedTypeNode
456456
Name(int)
457457
Identifier(int)
458-
Stmt\Callable\ParameterNode(optional)
458+
Stmt\Callable\CallableParameterNode(optional)
459459
Stmt\NamedTypeNode
460460
Name(int)
461461
Identifier(int)
@@ -467,13 +467,13 @@ public static function typesDataProvider(): iterable
467467
Stmt\CallableTypeNode
468468
Name(callable)
469469
Identifier(callable)
470-
Stmt\Callable\ParametersListNode
471-
Stmt\Callable\ParameterNode(simple)
470+
Stmt\Callable\CallableParametersListNode
471+
Stmt\Callable\CallableParameterNode(simple)
472472
Stmt\NamedTypeNode
473473
Name(int)
474474
Identifier(int)
475475
Literal\VariableLiteralNode($foo)
476-
Stmt\Callable\ParameterNode(simple)
476+
Stmt\Callable\CallableParameterNode(simple)
477477
Stmt\NamedTypeNode
478478
Name(string)
479479
Identifier(string)
@@ -486,8 +486,8 @@ public static function typesDataProvider(): iterable
486486
Stmt\CallableTypeNode
487487
Name(callable)
488488
Identifier(callable)
489-
Stmt\Callable\ParametersListNode
490-
Stmt\Callable\ParameterNode(output)
489+
Stmt\Callable\CallableParametersListNode
490+
Stmt\Callable\CallableParameterNode(output)
491491
Stmt\NamedTypeNode
492492
Name(string)
493493
Identifier(string)
@@ -500,8 +500,8 @@ public static function typesDataProvider(): iterable
500500
Stmt\CallableTypeNode
501501
Name(callable)
502502
Identifier(callable)
503-
Stmt\Callable\ParametersListNode
504-
Stmt\Callable\ParameterNode(variadic)
503+
Stmt\Callable\CallableParametersListNode
504+
Stmt\Callable\CallableParameterNode(variadic)
505505
Stmt\NamedTypeNode
506506
Name(float)
507507
Identifier(float)
@@ -516,8 +516,8 @@ public static function typesDataProvider(): iterable
516516
Stmt\CallableTypeNode
517517
Name(callable)
518518
Identifier(callable)
519-
Stmt\Callable\ParametersListNode
520-
Stmt\Callable\ParameterNode(variadic)
519+
Stmt\Callable\CallableParametersListNode
520+
Stmt\Callable\CallableParameterNode(variadic)
521521
Stmt\NamedTypeNode
522522
Name(float)
523523
Identifier(float)
@@ -531,12 +531,12 @@ public static function typesDataProvider(): iterable
531531
Stmt\CallableTypeNode
532532
FullQualifiedName(\Closure)
533533
Identifier(Closure)
534-
Stmt\Callable\ParametersListNode
535-
Stmt\Callable\ParameterNode(simple)
534+
Stmt\Callable\CallableParametersListNode
535+
Stmt\Callable\CallableParameterNode(simple)
536536
Stmt\NamedTypeNode
537537
Name(int)
538538
Identifier(int)
539-
Stmt\Callable\ParameterNode(simple)
539+
Stmt\Callable\CallableParameterNode(simple)
540540
Stmt\NamedTypeNode
541541
Name(int)
542542
Identifier(int)

tests/Unit/Types/TernaryTypesTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public static function typesDataProvider(): iterable
3434
Stmt\CallableTypeNode
3535
Name(foo)
3636
Identifier(foo)
37-
Stmt\Callable\ParametersListNode
37+
Stmt\Callable\CallableParametersListNode
3838
STMT];
3939
4040
yield '$this' => ['$this', <<<'STMT'

0 commit comments

Comments
 (0)