Fix psalm / CI issues

Author: veewee

.github/workflows/tests.yaml

@@ -25,4 +25,3 @@ jobs:
               run: composer update --prefer-dist --no-progress --no-suggest ${{ matrix.dependency-preference == 'lowest' && '--prefer-lowest' || '' }} ${{ matrix.dependency-preference == 'stable' && '--prefer-stable' || '' }} ${{ matrix.composer-options }}
             - name: Run the tests
               run: ./vendor/bin/phpunit
-              continue-on-error: ${{ matrix.php-versions == '8.5'}}

composer.json

@@ -31,7 +31,7 @@
         "psalm/plugin-symfony": "^5.0",
         "php-standard-library/psalm-plugin": "^2.2",
         "vimeo/psalm": "~6.13.0",
-        "phpunit/phpunit": "~12.3.0",
+        "phpunit/phpunit": "~12.4.0",
         "php-cs-fixer/shim": "~3.88.0"
     },
     "license": "MIT",

src/Console/UI/Components/MetaTable.php

@@ -15,6 +15,7 @@
 use ReflectionProperty;
 use Throwable;
 use function Psl\Dict\filter_nulls;
+use function Psl\Json\encode;
 use function Psl\Vec\map;
 
 final readonly class MetaTable
@@ -71,7 +72,7 @@ private static function tryStringifyValue(mixed $value): ?string
     {
         try {
             return match (true) {
-                is_array($value) => json_encode($value, JSON_UNESCAPED_SLASHES),
+                is_array($value) => encode($value, pretty: false, flags: JSON_UNESCAPED_SLASHES),
                 is_bool($value) => $value ? 'true' : 'false',
                 is_scalar($value) => (string)$value,
                 $value instanceof Option => $value->map(self::tryStringifyValue(...))->unwrapOr(null),

src/Console/UI/Components/ScrollableTextAreaState.php

@@ -6,7 +6,7 @@
 use PhpTui\Term\MouseEventKind;
 use Soap\WsdlReader\Console\UI\EventHandler;
 
-use function json_encode;
+use function Psl\Json\encode;
 use function Psl\Math\max;
 use function Psl\Math\min;
 
@@ -21,7 +21,7 @@ public function __construct(
     public static function json(mixed $data, string $fallback): self
     {
         return new self(
-            $data !== null ? json_encode($data, JSON_PRETTY_PRINT + JSON_UNESCAPED_SLASHES) : $fallback,
+            $data !== null ? encode($data, pretty: true, flags: JSON_UNESCAPED_SLASHES) : $fallback,
         );
     }
 

src/Formatter/MetaTableFormatter.php

@@ -9,6 +9,7 @@
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Output\OutputInterface;
 use Throwable;
+use function Psl\Json\encode;
 use function Psl\Vec\filter_nulls;
 use function Psl\Vec\map;
 
@@ -56,7 +57,7 @@ private function tryStringifyValue(mixed $value): ?string
     {
         try {
             return match (true) {
-                is_array($value) => json_encode($value, JSON_PRETTY_PRINT),
+                is_array($value) => encode($value, pretty: true),
                 is_bool($value) => $value ? 'true' : 'false',
                 is_scalar($value) => (string)$value,
                 $value instanceof Option => $value->map($this->tryStringifyValue(...))->unwrapOr(null),

tests/PhpCompatibility/test_schema.inc

@@ -8,7 +8,11 @@ use Soap\WsdlReader\Formatter\ShortMethodFormatter;
 use Soap\WsdlReader\Metadata\Wsdl1MetadataProvider;
 use Soap\WsdlReader\Wsdl1Reader;
 
+// Avoid deprecated warnings to be displayed during the test output for the loaded dependencies.
+// This is causing issues on lower dependencies.
+$previousReporting = error_reporting(E_ALL ^ E_DEPRECATED);
 require_once __DIR__.'/../bootstrap.php';
+error_reporting($previousReporting);
 
 function test_schema($schema, $type, $style="rpc",$use="encoded", $attributeFormDefault='')
 {