Skip to content

Commit 7c13dac

Browse files
committed
Fix tests
1 parent e9776bb commit 7c13dac

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

test/RequestIdMiddlewareTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,12 @@ public function testNotEmmitRequestIdToResponse()
7474

7575
public function testTryToGetRequestIdBeforeRunMiddleware()
7676
{
77-
$this->setExpectedException(MissingRequestId::class);
78-
7977
$requestIdProviderFactory = $this->createMock(RequestIdProviderFactoryInterface::class);
8078

8179
$middleware = new RequestIdMiddleware($requestIdProviderFactory);
80+
81+
$this->expectException(MissingRequestId::class);
82+
8283
$middleware->getRequestId();
8384
}
8485
}

test/RequestIdProviderTest.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,13 @@ public function testGenerateIdBecauseNotExistInHeader()
3535
*/
3636
public function testTryToGenerateEmptyRequestId($emptyValue)
3737
{
38-
$this->setExpectedException(InvalidRequestId::class);
39-
4038
$this->generator->expects($this->once())->method('generateRequestId')->willReturn($emptyValue);
4139

4240
$request = new ServerRequest();
4341
$provider = new RequestIdProvider($request, $this->generator);
4442

43+
$this->expectException(InvalidRequestId::class);
44+
4545
$provider->getRequestId();
4646
}
4747

@@ -89,11 +89,13 @@ public function testDoNotGenerateBecouseHeaderExists()
8989

9090
public function testDoNotGenerateBecauseHeaderExistsButEmpty()
9191
{
92-
$this->setExpectedException(MissingRequestId::class);
9392
$this->generator->expects($this->never())->method('generateRequestId');
9493
$request = new ServerRequest([], [], 'https://github.com/php-middleware/request-id', 'GET', 'php://input', [RequestIdProvider::DEFAULT_REQUEST_HEADER => '']);
9594

9695
$provider = new RequestIdProvider($request, $this->generator);
96+
97+
$this->expectException(MissingRequestId::class);
98+
9799
$provider->getRequestId();
98100
}
99101

0 commit comments

Comments
 (0)