-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable routing #501
Comments
The |
I've posted a possible solution with #500 (comment). |
internally route via the yo-rc-workspace.json, externally via nginx config - and please don't override the webpack configs |
Finally really solved by #504 |
Short description
Currently the routing is done in dev via the config/webpack.dev.js and in prod via nginx in deploy/web/nginx-default.conf and copying over the generated deploy files.
Side info: The existance of config.webpack.prod.js isn't clear (Is it to generate a different deploy folder?), as we are (hopefully) not using nodejs/webpack as a webserver in prod.
It's also nearly 1:1 the dev file, with some minor changes in some places (so having 1 file that is configurable by args / env-vars / some .json settings would be nicer)
User stories
Just like the .dockerignore issue #500, this is done via a generators/workspace/templates/ file, and the behaviour can't easily be overridden,
In reprovisyn we want to route
Other tools also employ multiple "microservice"-subservers (i.e. marvinjs) and to avoid CORS, such a routing strategy would be nice.
Possible solutions
Just like the .dockerignore issue, we'd like to make the routing at least configurable - there are multiple possible options:
a) Via allowing to override the webpack.dev.js (and the nginx-default.conf, which already works) - currently having one in the /template/config does nothing and having it in /config leads to phovea:update / phovea:setup-workspace asks you if you want to replace it by the default. (Expected behaviour: some way to override the default webpack.dev.js)
b) by generating the routes to webpack and nginx conf from some config (probably phovea_product.json?) or a new one.
Also at least some documentation for the webpack.prod file would be nice, as well as some documentation on how to override such a behaviour.
The text was updated successfully, but these errors were encountered: