Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupt Package Data when downloading #2

Open
jaredramirez opened this issue Jan 10, 2023 · 9 comments
Open

Corrupt Package Data when downloading #2

jaredramirez opened this issue Jan 10, 2023 · 9 comments

Comments

@jaredramirez
Copy link

Hey there, starting yesterday our local & CI installs started to fail with the following problem:

Starting downloads...

  ✗ phosphor-icons/phosphor-elm 1.0.2

Dependency problem!
-- CORRUPT PACKAGE DATA --------------------------------------------------------

I downloaded the source code for phosphor-icons/phosphor-elm 1.0.2 from:

    https://github.com/phosphor-icons/phosphor-elm/zipball/1.0.2/

But it looks like the hash of the archive has changed since publication:

  Expected: 9dcc8add1bd1b43db686c7c228764e5d03908e62
    Actual: 28db295525e42c116eda1974ce4b7e6fee451b43

This usually means that the package author moved the version tag, so report it
to them and see if that is the issue. Folks on Elm slack can probably help as
well.

Did something change with the 1.0.2 tag in this repo that caused the change?

I did some googling and saw that in the past something like this seems to have been caused by a github issue: dillonkearns/elm-graphql#581 (comment), so maybe there's nothing that can be done here. I've also asked about this on the Elm community slack

@rektdeckard
Copy link
Member

Hi @jaredramirez, sorry to hear about that! I recently renamed this repo, it is possible that has something to do with it, now that the name field in elm.json is no longer correct. I guess I made the assumption that Github redirects would hold here too.

Thanks for the issue. Will try to push out a patch today.

@jaredramirez
Copy link
Author

Ah, yes that's probably it! Thanks for the prompt reply!

@lue-bird
Copy link

lue-bird commented Jan 10, 2023

And I don't think package owners can do anything about it except renaming back maybe (?).
Something something github hash is different after renaming

@jaredramirez
Copy link
Author

Or republish under a slightly different name?

@lue-bird
Copy link

lue-bird commented Jan 10, 2023

Yeah publishing a new package with the current repo name phosphor-icons/elm has to be done anyway.
Best to then also publish another version under the phosphor-icons/elm-phosphor name leaving a note redirecting to the new package with the name phosphor-icons/elm

@rektdeckard
Copy link
Member

Or maybe just rename the repo back? I'm not super knowledgeable about the Elm ecosystem, best-practices, etc. Will defer to you all on best approach.

@rektdeckard
Copy link
Member

rektdeckard commented Jan 10, 2023

Ideally this would be published at @phosphor-icons/elm to match the org namespacing on NPM and planned relocations we have for our other JS packages. Not sure if that's a thing on package.elm-lang.org though.

@rektdeckard
Copy link
Member

Temporarily reverted the rename, your projects should be building now (just tested on a bare app).

@jaredramirez
Copy link
Author

I think the best thing is what @lue-bird suggested.

  1. In the current (now with the reverted name) package, update the readme saying this package is deprecated
  2. Rename the repo & package name
  3. Republish a "new" elm package under the new name as v1.0.0 (elm packages auto-namespace based on the github org/owner's name)

Then I, or anyone else, can update our apps to use the newly named version and the repo's naming scheme is consistent with all y'alls other packages/planned changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants