Can't use numpad for activating links

[asgerhallas]

I have changed my hint letters to 0123456789 and are now trying to activate the links using the numpad, but nothing happens. It works fine when using the other numeric keys.

Is this by design or a bug?

Chrome: 28.0.1500.71 (Official Build 209842) m
Vimium: 1.43

[asgerhallas]

Great extension by the way!!! :)

[philc]

Great bug. This will require some debugging -- I'm not sure whether we're switching on the key char or key code, but if it's the key code, that may cause different behavior between regular numbers and numpad keys.

[thynctank]

Was this ever fixed? I just reported an identical issue in Vrome!

[dragon788]

Sadly I don't have my numpad equipped laptop nearby to test, but I'm almost certain that the numpad does send different keyscan codes than the number row, but as philc said, matching shouldn't be tough.

[thynctank]

I committed a fix for the equivalent issue in vrome which is working just fine for me. It was merged in but I’m not sure it’s been released to the store or whatever.

[smblott-github]

Looks like this is @thynctank's fix in vrome.

[thynctank]

Aye! Thanks for dredging it up!

On Sunday, May 10, 2015, Stephen Blott [email protected] wrote:

Looks like this
thynctank/vrome@3b776a8
is @thynctank https://github.com/thynctank's fix in vrome.

—
Reply to this email directly or view it on GitHub
#879 (comment).

Sent from my Mobile

[mrmr1993]

Alternatively, we could stop using a keydown listener for character filtering in link hints, and use a keypress one instead. This will automatically fix this issue and the internationalisation issues we've been seeing for link hints.

Edit: keypress won't work properly with modifer keys, so this won't work for us.