Port overlapping link hint rotation by Space from VimFx #1252
Conversation
|
This is very cool! I've created a pull request on your branch that fixes the shift behaviour and adds shift-space as a shortcut. |
|
How could we to document this so that users know about it? |
|
Thank you for the pull request, I am unaware what is the intended Shift behaviour so decided not to change anything there. |
Stop link hints from handling shift incorrectly
|
Two comments:
I suspect this PR is against an hopelessly old code base; so I'll close it for now. (Correct me if I'm mistaken.) A new PR would be welcome. |
|
This feature is pretty useful in the occasions when the web app interface is full of little icons, for example. Another claim in its favor is that you may try once and remember - if you happen to be forced to use some repetitive interface, being able to use Vimium to speed up your regular navigation is beneficial. I remember myself wishing several times that this feature is implemented in Vimium, but it was mainly back when GMail support was not that polished. Yes, the code base is like over a year old, I didn't update the PR 'cause there was no significant reaction. But @mrmr1993 had merged it into his own fork then, so if he had kept it up to date through the code base changes, maybe we could have a more modern implementation of this. If this is not the case, I'll try to reimplement the PR against the current upstream. |
|
As a VimFx user:
(Also, it’s VimFx, not VimFX, hehe :) ) |
We recognise elements with a class names containing the text "button" as clickable. However, often they're not, they're just wrapping a clickable thing, like a real button. Here, we filter out such false positives. This has two effects: - It eliminates quite a number of real false pasitives in practice. - With fewer hints close together, fewer hint markers are obscured by the hints from (non-clickable) wrappers. This reduces the need for rotating the hint stacking order, e.g philc#1252.
We recognise elements with a class names containing the text "button" as clickable. However, often they're not, they're just wrapping a clickable thing, like a real button. Here, we filter out such false positives. This has two effects: - It eliminates quite a number of real false pasitives in practice. - With fewer hints close together, fewer hint markers are obscured by the hints from (non-clickable) wrappers. This reduces the need for rotating the hint stacking order, e.g philc#1252.
This commit basically ports the VimFx'es ability to rotate overlapping marker stacks by pressing [Shift-]Space. This is very useful in the cases where many little (e.g. iconic) links are stuffed together. Resolves #757.