Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: being able to toggle fullscreen #4596

Open
kbilsted opened this issue Dec 27, 2024 · 3 comments
Open

feature request: being able to toggle fullscreen #4596

kbilsted opened this issue Dec 27, 2024 · 3 comments

Comments

@kbilsted
Copy link

F11 toggles the full screen (at least on firefox) but it is a horrible position on the keyboard, can vimium be extended to allow me to remap the fullscreen toggle to a sensible key?
@philg-dev
Copy link

F11 enters the browser's fullscreen mode. I'm almost certain that there's no API to trigger that, because it's a browser specific feature. In Firefox, it will display the page in fullscreen and when you move the mouse towards the top of the screen the tabs and URL bar will appear.

From what I've seen there's only an API to trigger fullscreen on a page itself, as it is very common for pages like YouTube, Twitch, etc.

https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API

From what I understand this could probably be used to display the entire <body> element of a page in fullscreen, but according to the MDN page, this fullscreen will be exited upon changing tabs or pressing Esc.

I think there is no way to change the F11 shortcut in Firefox.

@kbilsted
Copy link
Author

thanks for the quick reply.

so if the plugin did this pr page we would see a lot of flickering when changing tabs?

function toggleFullScreen() {
  if (!document.fullscreenElement) {
    document.documentElement.requestFullscreen();
  } else if (document.exitFullscreen) {
    document.exitFullscreen();
  }
}
```

@philg-dev
Copy link

I'm not entirely sure how it would work when the fullscreen API is triggered in a rapid fashion like that (leaving upon tab change and immediately entering fullscreen on the new current tab).

I've seen a bunch of flags in about:config regarding the fullscreen API, and at least one of them mentioned some kind of delay.

The bigger problem that I would be worried about, is that the fullscreen from the API will not offer the URL bar and the tabs when moving the mouse to the top, like the browser-native fullscreen with F11 does.

You could potentially test your code snippet fairly easily with a tampermonkey script, if you're curious about the potential flickering.

That might also be a good short-term solution for your issue anyway. I think the feature might be a little too exotic to make it's way into Vimium with the potential issues we've just discussed. Unless somebody knows a better solution of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kbilsted @philg-dev