Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination does not always occur with the active window #4066

Open
code86 opened this issue May 31, 2022 · 2 comments
Open

Pagination does not always occur with the active window #4066

code86 opened this issue May 31, 2022 · 2 comments

Comments

@code86
Copy link

code86 commented May 31, 2022

Describe the bug
Pagination does not always occur with the active window (document.activeelement).

Include a screenshot if applicable.
animated gif

To Reproduce
Steps to reproduce the behavior:

  1. Go to URL 'https://www.nytimes.com/2022/05/31/us/america-grief-life.html'
  2. Using Vimium, click on 'Read Comments' (at bottom of article)
  3. Using Vimium, click on 'Reader Picks'
  4. Using Vimium, scroll page up / down.
  5. Notice it is the underlying article that is scrolled, and not the comments itself.

Browser and Vimium version
Chrome browser
Vimium version 1.67

If you're using Chrome, include the Chrome and OS version found at chrome://version. Also include the Vimium version found at chrome://extensions.

Google Chrome 102.0.5005.61 (Official Build) (arm64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 12.4 (Build 21F79)
JavaScript V8 10.2.154.4
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.61 Safari/537.36
@gdh1995
Copy link
Contributor

gdh1995 commented Jun 1, 2022

Some tricks in #3760 (comment) can work it around. And #4016 may be a usable solution.

@trysten
Copy link

trysten commented Feb 16, 2023

I found that Vimium doesn't seem to catch focus events I'm generating from devtools or extensions like so:

document.getElementsByClassName('page-content')[0].focus()

on this web page for example. This focus event works to scroll content with the arrow keys but not Vimium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants