Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keypress lag when using LinkHints (Chrome 51.0.2704.63 beta-m [64-bit] on Win10; Vimium 1.55) #2148

Open
c0ldk453 opened this issue May 29, 2016 · 2 comments

Comments

@c0ldk453
Copy link

I love this extension and use it a lot. However, the recent update is much slower on certain sites. (www.kissanime.to is the site I've mainly had issues with so far [do be aware that I do use AdBlock and Tampermonkey to disable all ads, so those aren't the issue]) It takes one to two seconds to register each keypress. If a fix can be found, that would be great.

@smblott-github
Copy link
Collaborator

Thanks, @c0ldk453. I can't reproduce on that site -- link hints are snappy for me there. Is there a specific page?

However, what you describe is possible. This relates to global link hints and there are two issues at play:

  • Vimium now displays hints for all frames in a page, so this means we're collecting more hints and doing more work. Most of the time this is helpful (you can do stuff you couldn't do before), but occasionally it is slower.
  • On some pages, there are out-of-viewport frames containing many links. We cannot detect whether a frame is within the viewport so, in these cases, we end up generating considerably more hints than necessary, hence doing more work than necessary.

@c0ldk453
Copy link
Author

I figured it out. It's how Vimium interacts with the Disqus plugin on the site. It's likely something to do with what you spoke of. Do try testing it out with sites that use the Disqus comment plugin. That's my best guess. When I disable Disqus commenting in my personal preferences, it works normally again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants