Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False mapping of API invocation #2121

Closed
Edenhofer opened this issue Apr 30, 2016 · 4 comments
Closed

False mapping of API invocation #2121

Edenhofer opened this issue Apr 30, 2016 · 4 comments

Comments

@Edenhofer
Copy link

Edenhofer commented Apr 30, 2016

Triggering LinkHints.activateMode does not open a link in the current tab like the documention suggests, however LinkHints.activateModeToOpenInNewTab does. The statement is also true the other way aroung. Both invocations are simply switched in their meaning.

Chrome Version: Linux 50.0.2661.94
Vivaldi Version: 1.1.453.47
Vimium Version: 1.54

@innaterebel
Copy link

Caps lock? :)

@Edenhofer
Copy link
Author

To be honest, this was my first thought as well. But after double checking that, I can say for sure that caps lock is turned off.

@mrmr1993
Copy link
Contributor

Pressing <shift> while typing the link hint characters inverts the mode (so you can decide to open a new tab while already in link hints mode). If you're holding <shift>, don't, and the commands should work as expected.

#1928 and #1867 are relevent.

@Edenhofer
Copy link
Author

Apologies for my stupidity! Thanks @mrmr1993 for the hint. The capital letters next to each link led me to think I needed to press <shift>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants