Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next/previous shortcuts cause annoying page scroll #1909

Open
sid-kap opened this issue Dec 9, 2015 · 2 comments
Open

Next/previous shortcuts cause annoying page scroll #1909

sid-kap opened this issue Dec 9, 2015 · 2 comments

Comments

@sid-kap
Copy link

sid-kap commented Dec 9, 2015

When I press [[ or ]], the page usually scrolls down a bit, even if the "Previous" or "Next" text was already in the viewport.

To reproduce: go to http://abstrusegoose.com/570, increase zoom to around 150% (large enough so that the page doesn't fit in a single frame, and the scrollbar appears), and then hit [[ or ]].

What might be causing this? How could I fix this?

@smblott-github
Copy link
Collaborator

@mrmr1993...

It looks like that's pretty old code here. Do we know that the scroll and focus are needed? It seems to still work without them.

@mrmr1993
Copy link
Contributor

I assume the intention was to show which link we are following (especially useful when users report the wrong link is selected, so they can tell us which).

I vaguely remember that element.scrollIntoFocus doesn't always scroll or not as expected, but I'm not sure what should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants