Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with YouTube playlist dropdown and other video player hotkeys #1882

Open
kenorb opened this issue Nov 7, 2015 · 5 comments
Open

Comments

@kenorb
Copy link

kenorb commented Nov 7, 2015

When I'm trying to add some video to the playlist, and I type 'free', it doesn't let me, as it's refreshing the page (probably on r keystroke).

I'm using: Version 1.53

@smblott-github
Copy link
Collaborator

Ouch!
Confirmed.

@smblott-github
Copy link
Collaborator

Here's what's happening...

Whenever the typed keys match existing playlists, youtube refreshes the list of playlists and blurs the input (so Vimium drops out of insert mode, as it should). Youtube is then catching keys elsewhere, and inserting them into the input. Depending upon the characters typed and the matching playlists, the input may or may not be focused, so Vimium may or may not be in insert mode.

Because Vimium isn't in insert mode, keys like r (or worse still x!) are handled by Vimium, with undesirable effects.

Workaround? I can't think of anything better than disabling Vimium on youtube.

@ghost
Copy link

ghost commented Feb 2, 2016

What needs to be disabled for the most part is not Vimium at all, but Youtube hotkeys themselves. I suggest a Vimium plugin for this special case, since it is one of the most widely used website on the interwebz.

@smblott-github
Copy link
Collaborator

Thanks, @jellytux. However, it's not actually YoutTube hotkeys that are causing the problem. The user is typing text into what looks like an input, which is kind of fundamental to the page. Except, sometimes it is a real input, and sometimes it's not. It's just the weird way YouTube have implemented their interface.

@ghost
Copy link

ghost commented Feb 3, 2016

@smblott-github I don't think this is the only issue though, video player hotkeys also conflict. You could just disable Vimium if any inputs are focused, that shouldn't be too hard to implement.

@kenorb kenorb changed the title Conflict with YouTube playlist dropdown Conflict with YouTube playlist dropdown and other video player hotkeys Feb 4, 2016
mrmr1993 added a commit to mrmr1993/vimium that referenced this issue Feb 26, 2016
This fixes issue philc#1882. Justification given in the added comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants