Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search across all frames of a tab #1319

Open
maximbaz opened this issue Dec 15, 2014 · 9 comments
Open

Search across all frames of a tab #1319

maximbaz opened this issue Dec 15, 2014 · 9 comments

Comments

@maximbaz
Copy link

Similarly as link hints are not shown in all frames (see #602), search with / also works only in the current frame.
#1182 does not fix it, but is most probably related.

@jaekyeom
Copy link

Does someone have a plan for this?

@mrmr1993
Copy link
Contributor

No plan per se, but a fix for #1118 should provide a nice starting point for this, since whatever we do for <input>/<textarea> searches could plausibly also be done for <iframe>s (albeit asynchronously, which could cause timing issues etc.).

@ryepesg
Copy link

ryepesg commented Dec 9, 2015

Maybe the easy way is just mapping / to Ctrl+f, like VimFX does.

@mrmr1993
Copy link
Contributor

mrmr1993 commented Dec 9, 2015

the easy way

This isn't currently possible in chrome.

@lindhe
Copy link

lindhe commented Aug 15, 2017

This really needs to be fixed. The extension is completely useless as soon as I get to a page build with iFrames... (as if those pages weren't bad enough already)

@mrmr1993
Copy link
Contributor

The extension is completely useless as soon as I get to a page build with iFrames...

You should be able to use gf to switch frame to the one you want to search in. Not ideal, but it does work.

@lindhe
Copy link

lindhe commented Aug 15, 2017

Does not work for me. At least I'm stuck when on this page. Can't scroll, can't put hints on links, can't switch tabs (except for just after I refresh the page), can't go full top or bottom, can't to jack.

EDIT: And of course: gf and gF does nothing. Just after refreshing, gF puts a yellow border around the page, so I guess it tries to do something, but I don't notice any difference. Does not even flash me the yellow border if I click on the page body first.

@mrmr1993
Copy link
Contributor

Does not work for me.

Works for me. For your example page, I have to press gf several (3) times to get to the scrolling frame.

You can also set the option "Use the link's name and numbers for link-hint filtering" in the options page (click the advanced options first), and then you can select the frame you want using link hints (f).

@lindhe
Copy link

lindhe commented Aug 15, 2017

Odd. That does not work for me either. I'll try again tomorrow or something like that, with a clean FF profile and Vimium config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants