Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback from testing: Updates to functions #69

Open
1 task
manciniedoardo opened this issue Dec 23, 2024 · 0 comments · May be fixed by #77
Open
1 task

Feedback from testing: Updates to functions #69

manciniedoardo opened this issue Dec 23, 2024 · 0 comments · May be fixed by #77
Assignees
@yurovska
Labels
Feedback from testing

Comments

@manciniedoardo
Copy link
Collaborator

manciniedoardo commented Dec 23, 2024 •
edited
Loading

Background Information

The updates below were suggested from package testing.

Definition of Done

  • If units are converted in derive_param_waisthgt(), the message is labelled as "ALERT":
 #> ℹ ALERT: Unit conversion performed for "HEIGHT". Values converted from "cm" to
 #> "in".

Remove text "ALERT" - maybe replace with "Note"?
@yurovska yurovska self-assigned this Jan 2, 2025
yurovska pushed a commit that referenced this issue Jan 2, 2025
#69 Replaced ALERT with Note
4ab4ba0
@yurovska yurovska linked a pull request Jan 2, 2025 that will close this issue
Closes #69 Feedback from testing: Updates to functions #77
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurovska yurovska

Labels
Feedback from testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #69 Feedback from testing: Updates to functions pharmaverse/admiralmetabolic
2 participants
@manciniedoardo @yurovska