Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: run app via package installation #122

Open
4 tasks
Gotfrid opened this issue Nov 15, 2024 · 0 comments · May be fixed by #123
Open
4 tasks

Enhancement: run app via package installation #122

Gotfrid opened this issue Nov 15, 2024 · 0 comments · May be fixed by #123
Assignees
Labels
enhancement New feature or request

Comments

@Gotfrid
Copy link
Collaborator

Gotfrid commented Nov 15, 2024

Description

Currently to run the app, one has to clone a repository. I think it might be a detractor for some non-technical folks. This is why I believe that we should be able to make it possible to run the app after installing the package from Github.

Implementation plan

  1. Prepare a reproducible environment with docker
  2. Update run_app function to require all required packages
  3. Update run_app function to be able to pass parameters to the underlying shiny::runApp function
  4. Add missing imports/packages to the run_app function, e.g. logger
  5. Make sure the app can be installed & run via reproducible environment
  6. Update the readme installation section
  7. Bump package version

Definition of Done

  • user can install the package from github via pak::pak("pharmaverse/aNCA")
  • user can run the app via aNCA::run_app()
  • README contains information on how to install & run the app
  • Package version is bumped
@Gotfrid Gotfrid added this to aNCA Nov 15, 2024
@Gotfrid Gotfrid self-assigned this Nov 15, 2024
@Gotfrid Gotfrid converted this from a draft issue Nov 15, 2024
@Gotfrid Gotfrid added the enhancement New feature or request label Nov 15, 2024
@Gotfrid Gotfrid linked a pull request Nov 15, 2024 that will close this issue
8 tasks
@Gotfrid Gotfrid linked a pull request Nov 15, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant