Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support spliting a gesture into multiple actions #7

Closed
pguedes opened this issue Oct 25, 2020 · 3 comments · May be fixed by #8
Closed

support spliting a gesture into multiple actions #7

pguedes opened this issue Oct 25, 2020 · 3 comments · May be fixed by #8
Labels
enhancement New feature or request
Milestone
v0.2

Comments

@pguedes
Copy link
Owner

pguedes commented Oct 25, 2020

for example, when zooming currently we execute one action at the end of the full gesture e.g. ctrl+ .
It would be cool if we could say that every some variation of the pinch gesture execute one ctrl+
@pguedes pguedes added the enhancement New feature or request label Oct 25, 2020
@Alsan
Copy link
Contributor

Alsan commented Nov 1, 2020

Do you mean combining multimple action keys (like swipe.left.3 = mod1+key1;mod2+key2), or joining multiple gestures as one gesture, just like the 'L' shape gesture? Or you want to inherit the behavior from the parent? Would you please explain more about the use case?

@pguedes
Copy link
Owner Author

pguedes commented Nov 10, 2020

I meant executing an action multiple times instead of just once when the gesture is done.

For example: currently when I want to zoom three times (like 3x Ctrl+ on my browser) I will do the pinch 3x... but I think a better way would be to trigger the Ctrl+ at every x pinch variation (a certain amount of the pinch gesture, in distance of fingers?) Like what tablets and phones do nowadays... I think it's more natural

@Alsan
Copy link
Contributor

Alsan commented Nov 10, 2020

Good point, but as my personal perference, zoom is a continuous action, and should be bind to every pinch update action. I'll try to implement this later these two days.

@pguedes pguedes linked a pull request Nov 17, 2020 that will close this issue
Pinch update #8
Open
pguedes pushed a commit that referenced this issue Nov 23, 2020
@Alsan @pguedes
#7 intermediate triggers for pinch gestures
0856718 
raise event on pinch update
configuration of triggers
  - trigger when scale threshold is reached
cleanup some mut pointer usage
ignore local history
@pguedes pguedes closed this as completed Jan 4, 2021
@pguedes pguedes added this to the v0.2 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2
Development

Successfully merging a pull request may close this issue.

Pinch update
2 participants
@Alsan @pguedes