Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format of array_alignment #9

Open
ea4gja opened this issue Aug 5, 2024 · 1 comment
Open

Format of array_alignment #9

ea4gja opened this issue Aug 5, 2024 · 1 comment

Comments

@ea4gja
Copy link

ea4gja commented Aug 5, 2024

In antennaArrayPattern.py, line 67, array alignment is said to be a 2D array. In directionEstimation.py, line 778, it is said to be a 1D array. In beamform.py, several points, it is unclear. In my view, the format should always be the same.

@ea4gja
Copy link
Author

ea4gja commented Aug 5, 2024

When the format is always the same, you can add two more functions: gen_uca_array_alignment, and gen_ula_array_alignment. This way, when the user uses an UCA or ULA array, he does not need to know array_alignment format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant