Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domain seperators on KeyHash/ValueHash #26

Closed
hdevalence opened this issue Mar 8, 2022 · 0 comments
Closed

Remove domain seperators on KeyHash/ValueHash #26

hdevalence opened this issue Mar 8, 2022 · 0 comments
Assignees

Comments

@hdevalence
Copy link
Member

It's cleaner and better to have domain separators for key and value hashes, so that we can't risk confusing key and value hashes, or a hash from some other part of some other protocol. But unfortunately, making domain separators work with ICS23 requires making changes to the ICS23 spec, and that will take time to roll out and cause incompatibility until the changes are adopted by every other deployment.

Instead, it seems better to take the slight cleanliness/design hit and drop the domain separators, so we don't have any compatibility concerns. The key and value hashes should just be straight SHA256 of their byte values.

@aubrika aubrika self-assigned this Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants