[Bug Report]: Excessive µs/t consumption on player with quantum armour w/ Moduels 29k+

[Halosos]

Minecraft Version

1.21.1

Mod Version

1,6,2

Did you test the latest version?

No

Severity

Performance

NeoForge Version

21.1.211

Describe the Issue

Full issue documentation: https://docs.google.com/spreadsheets/d/1ee_r-STM2SdC2wr7Pvm0FyTSaUfMfaTcwp3SAu9Whec/edit?gid=0#gid=0

TL;DR:

Any module, except flight, causes µs/t to rise to excessive levels.

E.G. No modules except water breathing had a µs/t of 6336 being used by the player.

Was unable to find fully consistent results with testing, but was inline with modules upping µs/t usage.

Reproduction Steps

Craft quantum armour
Install any moduel(s) except flight

Screenshots and Videos

Screenshots in documentation of issue: https://docs.google.com/spreadsheets/d/1ee_r-STM2SdC2wr7Pvm0FyTSaUfMfaTcwp3SAu9Whec/edit?gid=0#gid=0

Additional Context

Unsure if interaction with other mods are causing it, but

Crash log

https://gnomebot.dev/paste/mclogs/b4a1U5C

[pedroksl]

Is it possible for you to test it without the eternal starlight mod? Doesn’t need to be as thorough.

[Halosos]

Will give it a try. Might take a mo, not edited a modpack before

[pedroksl]

Make a full copy of your entire instance, then go in the mods folder and delete eternal starlight.
This makes sure you don't mess up your world or lose save data.

[pedroksl]

Let me just explain why I'm asking this.
Looking at your logs, I saw two interesting things.
First of them is the hot path includes a container menu, which implies this is happening with some ui open. Or at least the majority of it. (I would like to know if this was the amor configuration ui).

Second, the majority of the time happened in a lambda created by eternal starlight that is injecting itself into every slot changed in every other mod in the pack, taking up 20% of the entire processing time.

[Halosos]

That is weird.

I made a new instance and created a solo world just to test, but am having issues replicating the issue. there is something I have missed between the server I am on and my solo world. I honestly have no idea what it could be, I have not interacted with Eternal Starlight at all yet. I don't even know anything about the mod.

I am looking at all the items in it, I have never held any of those items, let alone crafted/used.

[Halosos]

P.S.

Even on the server, zero starlight interaction, yet with what you said, it is doing things to me.

[pedroksl]

Yeah, that's what I assumed.
Mod interactions, they do things they're not supposed to.
In this case, the interaction is caused by eternal starlight, and I'm not sure why yet.
There's one thing on my side that could have potentially made things worse, because I had one network packet that could cause more slot changes than needed that would trigger those eternal starlight listeners more often. I have changed this but it's not released yet, so you won't be able to test it for now.
For now my advice is to open an issue in their github too to see if we can figure this out.
P.S.: Remember to reference this issue there too, so they can see our discussion.

[Halosos]

Will do!

[pedroksl]

Hey, since I mentioned it in my last message, the change I talked about that could potentially minimize the issue is out.
If possible, test this again in the original modpack but with the latest version of AdvancedAE, to see if anything changed.
Hopefully that change helped a bit.

[Halosos]

I have had difficulty reproducing the issue outside of the server. Which means I will need to wait till atm10 is updated with it. I will try and get the devs to include your new version in their next update.

[allaehre]

Hey im having the same issue here, maybe the logs will help you some: (Had 38000 µs/t using all Modules)

It seems like Every tick → for every player → for every inventory change → it rebuilds, compares, and re-hashes huge sets of unlockable entries.

https://spark.lucko.me/so11oizrtu

I also tried giving me all ADvancements and made a post on Eternal Starlight: LeoMinecraftModding/eternal-starlight#156

[pedroksl]

Inventory changes are a re-occurring behavior. Every tick the armor uses FE and recharges. All those changes are saved/loaded in data components. However, there's something happening in eternal starlight that makes those changes take a lot longer than they should. I assume it's checking every tick for advancement conditions to unlock new entries.

I assume you tested with the newer version I release which tried to minimize the amount of updates that happened inside the quantum armor configuration screen, right? If this wasn't the issue, than it would probably boil down to normal updates of using/recharging battery, which are harder to reduce.

[allaehre]

Im playing on ATM10 Ver. 4.14 -> AdvancedAE Ver. 1.6.2-1.21.1.

I did try to update it to 1.6.6 (Client and Server) still no improvement sadly:

https://observable.tas.sh/p/GK5g4
https://spark.lucko.me/baZ0AESyym

Only Flight Card Enabled:

All Cards Enabled:

(I'am wearing the Mekanism Armor as a Cosmetic Armor my real one is the Quantum Armor.