Repeat runs

[JDHatman]

Hello. I use mac-defaults to manage several values. I have an entry that tries to reapply that manifest on each puppet run. All the rest of my entries only apply once unless changed. This is the first time I've tried an array.

Non-working example (This will apply on every puppet run)
mac-defaults { "additionalhttpheaders":
domain => '/Library/Preferences/ManagedInstalls',
key => 'AdditionalHttpHeaders',
type => 'array',
value => "Authorization: Basic XXXXXXXXXXXXXXXX",

Working examples (These will only apply once unless changed).
mac-defaults { "softwarerepourl":
domain => '/Library/Preferences/ManagedInstalls',
key => 'SoftwareRepoURL',
type => 'string',
value => "http://munkiserver1.orchard.fruit.com/munki_repo",

mac-defaults { "installapplesoftwareupdates":
domain => '/Library/Preferences/ManagedInstalls',
key => 'InstallAppleSoftwareUpdates',
type => 'bool',
value => "true",

[JDHatman]

I've figured out what the issue is. The following line is executed to determine if the current array value matches what it's supposed to be.

default => "defaults read $domain $key | grep -q $value"

Because $value is an array and not just a string, it returns this value. (Note the 4 opening spaces). Because of these opening spaces, it determines that the values don't match and it reapplies the manifest.

"Authorization: Basic XXXXXXXXXXXXXXXX"

As an interim fix, I modified the line inside of init.pp to show as this.

default => "defaults read $domain $key | grep -q $value | sed -e 's/ (.*)/\1/'"

That lops off the 4 opening spaces to return the correct value and now the manifest doesn't reapply. I realize that this is by no means a permanent fix, but it gets me by for now and hopefully you will find it useful.

Thanks!!

Jason

[grahamgilbert]

Hi,

I realise this is an old issue (somehow I missed it), but I'd love a pull request on this so I can merge it in.