Skip to content

Commit 4281459

Browse files
committed
Fix bug caused by param check being too strict.
1 parent e19e283 commit 4281459

File tree

1 file changed

+3
-22
lines changed

1 file changed

+3
-22
lines changed

src/Controller/AuthorizeController.php

+3-22
Original file line numberDiff line numberDiff line change
@@ -21,32 +21,13 @@ final public function __invoke(ServerRequestInterface $request, array $args): Re
2121

2222
$queryParams = $request->getQueryParams();
2323

24-
if (! isset($queryParams['request'])) {
25-
return $this->getResponse()
26-
->withStatus(400, "Bad request, missing request")
27-
;
28-
}
29-
3024
$parser = new \Lcobucci\JWT\Parser();
3125

32-
try {
33-
$token = $parser->parse($queryParams['request']);
34-
} catch (\Exception $exception) {
35-
return $this->getResponse()
36-
->withStatus(400, $exception->getMessage())
37-
;
38-
}
39-
4026
try {
27+
$token = $parser->parse($request->getQueryParams()['request']);
4128
$_SESSION["nonce"] = $token->getClaim('nonce');
42-
} catch(\OutOfBoundsException $e) {
43-
if (! isset($queryParams['nonce'])) {
44-
return $this->getResponse()
45-
->withStatus(400, "Bad request, missing nonce")
46-
;
47-
}
48-
49-
$_SESSION["nonce"] = $queryParams['nonce'];
29+
} catch(\Exception $e) {
30+
$_SESSION["nonce"] = $request->getQueryParams()['nonce'];
5031
}
5132

5233
/*/ Prepare GET parameters for OAUTH server request /*/

0 commit comments

Comments
 (0)