Skip to content

Commit b181d95

Browse files
committed
Suppress detekt lint error about too many returns.
1 parent 0fdc710 commit b181d95

File tree

2 files changed

+2
-25
lines changed

2 files changed

+2
-25
lines changed

CorePayments/src/main/java/com/paypal/android/corepayments/DeepLinkUtils.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ inline fun <reified T : DeepLink> buildDeepLink(
9090
}
9191
}
9292

93+
// TODO: see if we can resolve ReturnCount lint error instead of suppressing it
94+
@Suppress("ReturnCount")
9395
inline fun <reified T : DeepLink> captureDeepLink(
9496
intent: Intent,
9597
authState: String

CorePayments/src/main/java/com/paypal/android/corepayments/browserswitch/BrowserSwitchPendingState.kt

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.paypal.android.corepayments.browserswitch
22

3-
import android.content.Intent
43
import android.util.Base64
54
import androidx.annotation.RestrictTo
65
import androidx.core.net.toUri
@@ -28,30 +27,6 @@ data class BrowserSwitchPendingState(val originalOptions: BrowserSwitchOptions)
2827
return Base64.encodeToString(jsonBytes, flags)
2928
}
3029

31-
// TODO: consider renaming this method; "match" sounds like it returns a boolean
32-
fun match(
33-
intent: Intent,
34-
requestCode: Int,
35-
): BrowserSwitchFinishResult {
36-
if (requestCode != originalOptions.requestCode) {
37-
return BrowserSwitchFinishResult.RequestCodeDoesNotMatch
38-
}
39-
40-
val deepLinkUri = intent.data
41-
if (deepLinkUri == null) {
42-
return BrowserSwitchFinishResult.DeepLinkNotPresent
43-
}
44-
45-
val deepLinkScheme = deepLinkUri.scheme.orEmpty()
46-
val isMatchingDeepLink =
47-
deepLinkScheme.equals(originalOptions.returnUrlScheme, ignoreCase = true)
48-
return if (isMatchingDeepLink) {
49-
BrowserSwitchFinishResult.Success(deepLinkUri = deepLinkUri)
50-
} else {
51-
BrowserSwitchFinishResult.DeepLinkDoesNotMatch
52-
}
53-
}
54-
5530
companion object {
5631
fun fromBase64(base64EncodedJSON: String): BrowserSwitchPendingState? {
5732
val data = Base64.decode(base64EncodedJSON, Base64.DEFAULT)

0 commit comments

Comments
 (0)