[WIP] Replace HK2/Types/Parser/Scanner with Jandex and cache in the domain#7165
Draft
lprimak wants to merge 1 commit intopayara:mainfrom
Draft
[WIP] Replace HK2/Types/Parser/Scanner with Jandex and cache in the domain#7165lprimak wants to merge 1 commit intopayara:mainfrom
lprimak wants to merge 1 commit intopayara:mainfrom
Conversation
nucleus/common/internal-api/src/main/java/org/glassfish/internal/deployment/JandexIndexer.java
Show resolved
Hide resolved
This was referenced Jan 23, 2025
543e287 to
75c6091
Compare
bdfa809 to
aa27959
Compare
c4b0809 to
e9093da
Compare
91a9a95 to
d11a3f6
Compare
This was referenced Feb 26, 2025
This was referenced Mar 7, 2025
Contributor
Author
|
Update on the progress: Dependencies of this issue ballooned from a 3-day project to a 8-month behemoth. What this means is that I won't have any time to work on this til probably 2026 or later. Just to reiterate, I am not going abandon this (I never abandon anything) but currently the timing is not in this task's favor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy performance improvements
This is an experiment (for now)
This PR achieves at least 2X improvement when dependencies are not cached, which is a worst-case scenario.
I have seen as much as 5X performance improvement on a warmed-up JVM with dependencies cached,
with many dependencies.
Feedback is appreciated
Thank you.
Fixes #7079
issue-reproducers/cdi-unknownbdareproducerStructuredDeploymentTracing tracing = StructuredDeploymentTracing.load(context);tracing.startSpan(DeploymentTracing.AppStage.CLASS_SCANNING, source.getName());for each sourceDeploymentProperties.SKIP_SCAN_EXTERNAL_LIBsupportGenericAnnotationDetectorto see if it's getting used anywhere / use Jandex for it