Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with database syncing on the servers thread #127

Open
ryzech opened this issue Oct 7, 2021 · 1 comment
Open

Issue with database syncing on the servers thread #127

ryzech opened this issue Oct 7, 2021 · 1 comment

Comments

@ryzech
Copy link

ryzech commented Oct 7, 2021

craftconomy3-3.5.4-SNAPSHOT.jar//com.zaxxer.hikari.pool.ProxyPreparedStatement.executeUpdate(ProxyPreparedStatement.java:61)

Crafteconomy is making sync database calls to SQL on the servers main thread. This is locking the main thread of the server. So it throws errors and lags the server like crazy. I'm not sure if it's fixable but its quite an issue for my server.
@Phoenix616
Copy link

This can't be fixed as Vault expects all transactions to happen inside the method. And caching would open you up to desync exploits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Phoenix616 @ryzech