Skip to content

Commit 311c73b

Browse files
authored
Merge pull request #463 from kmcfaul/react-19-support
feat(ver): enable react 19 support
2 parents f547973 + 162e625 commit 311c73b

39 files changed

+112
-116
lines changed

.eslintrc.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
"plugin:react/recommended",
1010
"plugin:react-hooks/recommended",
1111
"plugin:@typescript-eslint/recommended",
12+
"plugin:react/jsx-runtime",
1213
"prettier"
1314
],
1415
"overrides": [

package-lock.json

Lines changed: 6 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/module/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
"react-jss": "^10.10.0"
4040
},
4141
"peerDependencies": {
42-
"react": "^17 || ^18",
43-
"react-dom": "^17 || ^18"
42+
"react": "^17 || ^18 || ^19",
43+
"react-dom": "^17 || ^18 || ^19"
4444
},
4545
"devDependencies": {
4646
"@patternfly/documentation-framework": "^6.5.20",
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React from 'react';
1+
import { FunctionComponent } from 'react';
22
import DataView from '@patternfly/react-data-view/dist/dynamic/DataView';
33

44
const layoutItemStyling = {
@@ -8,10 +8,10 @@ const layoutItemStyling = {
88
border: 'var(--pf-t--global--border--width--box--default) dashed var(--pf-t--global--border--color--default)'
99
};
1010

11-
export const BasicExample: React.FunctionComponent = () => (
11+
export const BasicExample: FunctionComponent = () => (
1212
<DataView>
1313
<div style={layoutItemStyling}>Header</div>
1414
<div style={layoutItemStyling}>Data representation</div>
1515
<div style={layoutItemStyling}>Footer</div>
1616
</DataView>
17-
)
17+
);

packages/module/patternfly-docs/content/extensions/data-view/examples/DataView/DataView.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ propComponents: ['DataView']
77
sortValue: 1
88
sourceLink: https://github.com/patternfly/react-data-view/blob/main/packages/module/patternfly-docs/content/extensions/data-view/examples/DataView/DataView.md
99
---
10-
import { useState, useEffect, useRef, useMemo } from 'react';
10+
import { FunctionComponent, useState, useEffect, useRef, useMemo } from 'react';
1111
import { Drawer, DrawerContent, DrawerContentBody } from '@patternfly/react-core';
1212
import { CubesIcon } from '@patternfly/react-icons';
1313
import { useDataViewPagination, useDataViewSelection, useDataViewFilters, useDataViewSort } from '@patternfly/react-data-view/dist/dynamic/Hooks';

packages/module/patternfly-docs/content/extensions/data-view/examples/DataView/EventsExample.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useEffect, useState, useRef, useMemo } from 'react';
1+
import { FunctionComponent, useEffect, useState, useRef, useMemo } from 'react';
22
import { Drawer, DrawerActions, DrawerCloseButton, DrawerContent, DrawerContentBody, DrawerHead, DrawerPanelContent, Title, Content } from '@patternfly/react-core';
33
import { DataView } from '@patternfly/react-data-view/dist/dynamic/DataView';
44
import { DataViewTable } from '@patternfly/react-data-view/dist/dynamic/DataViewTable';
@@ -32,7 +32,7 @@ interface RepositoryDetailProps {
3232
setSelectedRepo: React.Dispatch<React.SetStateAction<Repository | undefined>>;
3333
}
3434

35-
const RepositoryDetail: React.FunctionComponent<RepositoryDetailProps> = ({ selectedRepo, setSelectedRepo }) => {
35+
const RepositoryDetail: FunctionComponent<RepositoryDetailProps> = ({ selectedRepo, setSelectedRepo }) => {
3636
const context = useDataViewEventsContext();
3737

3838
useEffect(() => {
@@ -84,7 +84,7 @@ const rowActions = [
8484
}
8585
];
8686

87-
const RepositoriesTable: React.FunctionComponent<RepositoriesTableProps> = ({ selectedRepo = undefined }) => {
87+
const RepositoriesTable: FunctionComponent<RepositoriesTableProps> = ({ selectedRepo = undefined }) => {
8888
const selection = useDataViewSelection({ matchOption: (a, b) => a.row[0] === b.row[0] });
8989
const { trigger } = useDataViewEventsContext();
9090
const rows = useMemo(() => {
@@ -110,7 +110,7 @@ const RepositoriesTable: React.FunctionComponent<RepositoriesTableProps> = ({ se
110110
);
111111
};
112112

113-
export const BasicExample: React.FunctionComponent = () => {
113+
export const BasicExample: FunctionComponent = () => {
114114
const [ selectedRepo, setSelectedRepo ] = useState<Repository>();
115115
const drawerRef = useRef<HTMLDivElement>(null);
116116

packages/module/patternfly-docs/content/extensions/data-view/examples/DataView/PredefinedLayoutFullExample.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* eslint-disable no-nested-ternary */
2-
import React, { useEffect, useState, useRef, useMemo } from 'react';
2+
import { FunctionComponent, useEffect, useState, useRef, useMemo } from 'react';
33
import { Drawer, DrawerActions, DrawerCloseButton, DrawerContent, DrawerContentBody, DrawerHead, DrawerPanelContent, Title, Content, EmptyState, EmptyStateBody, EmptyStateFooter, EmptyStateActions, Button, } from '@patternfly/react-core';
44
import { ActionsColumn, Tbody, Td, ThProps, Tr } from '@patternfly/react-table';
55
import { BulkSelect, BulkSelectValue } from '@patternfly/react-component-groups/dist/dynamic/BulkSelect';
@@ -94,7 +94,7 @@ interface RepositoryDetailProps {
9494
setSelectedRepo: React.Dispatch<React.SetStateAction<Repository | undefined>>;
9595
}
9696

97-
const RepositoryDetail: React.FunctionComponent<RepositoryDetailProps> = ({ selectedRepo, setSelectedRepo }) => {
97+
const RepositoryDetail: FunctionComponent<RepositoryDetailProps> = ({ selectedRepo, setSelectedRepo }) => {
9898
const context = useDataViewEventsContext();
9999

100100
useEffect(() => {
@@ -146,7 +146,7 @@ const rowActions = [
146146
}
147147
];
148148

149-
const RepositoriesTable: React.FunctionComponent<RepositoriesTableProps> = ({ selectedRepo = undefined }) => {
149+
const RepositoriesTable: FunctionComponent<RepositoriesTableProps> = ({ selectedRepo = undefined }) => {
150150
const { filters, onSetFilters, clearAllFilters } = useDataViewFilters<RepositoryFilters>({ initialFilters: { name: '', branch: '', workspace: [] } });
151151

152152
const pagination = useDataViewPagination({ perPage: 5 });
@@ -255,7 +255,7 @@ const RepositoriesTable: React.FunctionComponent<RepositoriesTableProps> = ({ se
255255
);
256256
};
257257

258-
export const BasicExample: React.FunctionComponent = () => {
258+
export const BasicExample: FunctionComponent = () => {
259259
const [ selectedRepo, setSelectedRepo ] = useState<Repository>();
260260
const drawerRef = useRef<HTMLDivElement>(null);
261261

packages/module/patternfly-docs/content/extensions/data-view/examples/Table/DataViewTableEmptyExample.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import React from 'react';
1+
import { FunctionComponent } from 'react';
22
import { DataView, DataViewState } from '@patternfly/react-data-view/dist/dynamic/DataView';
33
import { DataViewTable, DataViewTr, DataViewTh } from '@patternfly/react-data-view/dist/dynamic/DataViewTable';
44
import { CubesIcon } from '@patternfly/react-icons';
5-
import { Button, EmptyState, EmptyStateActions, EmptyStateBody, EmptyStateFooter, } from '@patternfly/react-core';
5+
import { Button, EmptyState, EmptyStateActions, EmptyStateBody, EmptyStateFooter } from '@patternfly/react-core';
66
import { Tbody, Td, Tr } from '@patternfly/react-table';
77

88
interface Repository {
@@ -27,7 +27,7 @@ const empty = (
2727
<Tbody>
2828
<Tr key="loading" ouiaId={`${ouiaId}-tr-loading`}>
2929
<Td colSpan={columns.length}>
30-
<EmptyState headingLevel="h4" icon={CubesIcon} titleText="No data found">
30+
<EmptyState headingLevel="h4" icon={CubesIcon} titleText="No data found">
3131
<EmptyStateBody>There are no matching data to be displayed.</EmptyStateBody>
3232
<EmptyStateFooter>
3333
<EmptyStateActions>
@@ -44,10 +44,10 @@ const empty = (
4444
</Tbody>
4545
);
4646

47-
export const BasicExample: React.FunctionComponent = () => (
47+
export const BasicExample: FunctionComponent = () => (
4848
<DataView activeState={DataViewState.empty}>
49-
<DataViewTable
50-
aria-label='Repositories table'
49+
<DataViewTable
50+
aria-label="Repositories table"
5151
ouiaId={ouiaId}
5252
columns={columns}
5353
rows={rows}

packages/module/patternfly-docs/content/extensions/data-view/examples/Table/DataViewTableErrorExample.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React from 'react';
1+
import { FunctionComponent } from 'react';
22
import { DataView, DataViewState } from '@patternfly/react-data-view/dist/dynamic/DataView';
33
import { DataViewTable, DataViewTr, DataViewTh } from '@patternfly/react-data-view/dist/dynamic/DataViewTable';
44
import { ErrorState } from '@patternfly/react-component-groups';
@@ -32,7 +32,7 @@ const error = (
3232
</Tbody>
3333
);
3434

35-
export const BasicExample: React.FunctionComponent = () => (
35+
export const BasicExample: FunctionComponent = () => (
3636
<DataView activeState={DataViewState.error}>
3737
<DataViewTable
3838
aria-label='Repositories table'

packages/module/patternfly-docs/content/extensions/data-view/examples/Table/DataViewTableExample.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React from 'react';
1+
import { FunctionComponent } from 'react';
22
import { DataViewTable, DataViewTr, DataViewTh } from '@patternfly/react-data-view/dist/dynamic/DataViewTable';
33
import { ExclamationCircleIcon } from '@patternfly/react-icons';
44
import { Button } from '@patternfly/react-core';
@@ -62,6 +62,6 @@ const columns: DataViewTh[] = [
6262

6363
const ouiaId = 'TableExample';
6464

65-
export const BasicExample: React.FunctionComponent = () => (
65+
export const BasicExample: FunctionComponent = () => (
6666
<DataViewTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={rows} />
6767
);

0 commit comments

Comments
 (0)