Skip to content

Commit 604c958

Browse files
committed
feat(package): Update guidelines and templates
1 parent a4e82de commit 604c958

File tree

4 files changed

+47
-31
lines changed

4 files changed

+47
-31
lines changed

.github/CONTRIBUTING.md

+27-9
Original file line numberDiff line numberDiff line change
@@ -2,30 +2,48 @@
22

33
If you'd like to contribute to Pattern Lab Node, please do so! There is always a lot of ground to cover and something for your wheelhouse.
44

5-
No pull request is too small. Check out any [up for grabs issues](https://github.com/pattern-lab/patternlab-node/labels/up%20for%20grabs) as a good way to get your feet wet, or add some more unit tests.
5+
No pull request is too small. Check out any [help wanted 🆘](https://github.com/pattern-lab/patternlab-node/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted+%3Asos%3A%22) or [good first issues 🎓](https://github.com/pattern-lab/patternlab-node/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue+%3Amortar_board%3A%22)as a good way to get your feet wet, or add some more unit tests.
6+
7+
## Prerequisites
8+
9+
To get started, you'll need Node 8 or higher. Managing Node with [nvm](https://github.com/creationix/nvm) is recommended. Once installed, you can target the version of Node we specify within the [`.nvmrc`](https://github.com/pattern-lab/patternlab-node/blob/master/.nvmrc) file.
10+
11+
```sh
12+
nvm install <<version>>
13+
nvm use <<version>>
14+
```
615
716
## Developing Locally
817
9-
The best way to make changes to the Pattern Lab Node core and test them is through your existing edition.
18+
The best way to make changes to the Pattern Lab Node core and test them is through an edition.
1019
1120
* Fork this repository on Github.
21+
* `npm install && npm run bootstrap`
1222
* Create a new branch in your fork and push your changes in that fork.
13-
* `npm install`
14-
* `npm link`
15-
* `cd /path/to/your/edition`
16-
* `npm link patternlab-node`
23+
* `cd packages/edition-node`
24+
* Test your changes with the edition's api
25+
26+
### Cold start testing
27+
28+
To ensure that developers can bootstrap the repo from a fresh clone, do this in your working copy:
29+
30+
```sh
31+
git reset --hard && git clean -dfx && npm install && npm run bootstrap
32+
```
33+
34+
This ensures that any changes you've made will still result in a clean and functional developer experience. **Note**: be sure you've committed any outstanding work before doing this -- it will blow away whatever's still outstanding, including anything staged but not commited.
1735
1836
## Guidelines
1937
2038
* _ALWAYS_ submit pull requests against the [dev branch](https://github.com/pattern-lab/patternlab-node/tree/dev). If this does not occur, I will first, try to redirect you gently, second, attempt to redirect the target branch myself, thirdly, port over your contribution manually if time allows, and/or lastly, close your pull request. If you have a major feature to stabilize over time, talk to @bmuenzenmeyer via an issue about making a dedicated `feature-branch`
2139
* Keep your pull requests concise and limited to **ONE** substantive change at a time. This makes reviewing and testing so much easier.
2240
* Commits should reference the issue you are adressing. For any Pull Request that you send, use the template provided.
2341
* Commits are best formatted using the [conventional commits pattern](https://conventionalcommits.org/).
24-
* If you can, add some unit tests using the existing patterns in the `./test` directory
42+
* If you can, add some unit tests using the existing patterns in the `.packages/core/test` directory
2543
* Large enhancements should begin with opening an issue. This will result in a more systematic way for us to review your contribution and determine if a [specifcation discussion](https://github.com/pattern-lab/the-spec/issues) needs to occur.
2644
* Mention the issue number in commits, so anyone can see to which issue your changes belong to. For instance:
27-
* `#123 Fix resolving patterns in pattern_hunter`
28-
* `Feature #42: improve improbability drive`
45+
* `fix(get): Resolve patterns correctly`
46+
* `feat(version): Add ability to ask for version statically`
2947
3048
## Coding style
3149

.github/ISSUE_TEMPLATE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<!-- before posting an issue, verify you are running at least Node 6 -->
44

5-
I am using Pattern Lab Node `vX.X.X` on `Windows | Mac | Linux`, with Node `vX.X.X`, using the `Gulp | Grunt` Edition.
5+
I am using Pattern Lab Node `vX.X.X` on `Windows | Mac | Linux`, with Node `vX.X.X`, using a `Gulp | Grunt | Vanilla | Custom` Edition.
66

77
##### Expected Behavior
88

.github/PULL_REQUEST_TEMPLATE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!-- **Please read the contribution guidelines first, and target the `dev` branch!** -->
22

3-
Addresses #
3+
Closes #
44

55
Summary of changes:

README.md

+18-20
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,25 @@ If you'd like to see what a front-end project built with Pattern Lab looks like,
1818

1919
## Using Pattern Lab
2020

21+
Refer to the [core usage guidelines](https://github.com/pattern-lab/patternlab-node/blob/master/packages/core/README.md#usage)
22+
2123
### Installation
2224

23-
Installation is still in flux due to the monorepo transition. Bear with us as we figure this out.
25+
Installation is still in flux due to the monorepo transition. Bear with us as we figure this out. Our intent is to ship the Pattern Lab Node CLI soon which will help new and existing users.
26+
27+
_In the meantime..._
28+
29+
if you already have an Edition tracking 3.X alphas, you can update using the [standard instructions](https://github.com/pattern-lab/patternlab-node/wiki/Upgrading#3x-instructions).
30+
31+
if you don't mind pulling down everything and playing with it locally, clone this repo and follow the instructions for [developing locally](https://github.com/pattern-lab/patternlab-node/blob/master/.github/CONTRIBUTING.md#developing-locally).
32+
33+
if you don't yet have a 3.X compatible Edition and want to try something a bit messier (and unsupported for now), you could attempt this [workaround](https://github.com/pattern-lab/patternlab-node/issues/813).
34+
35+
## Ecosystem
36+
37+
![Pattern Lab Ecosystem](http://patternlab.io/assets/pattern-lab-2-image_18-large-opt.png)
38+
39+
Core, and Editions, are part of the [Pattern Lab Ecosystem](http://patternlab.io/docs/advanced-ecosystem-overview.html). With this architecture, we encourage people to write and maintain their own Editions, Starterkits, and even PatternEngines.
2440

2541
## Support for Pattern Lab
2642

@@ -35,22 +51,4 @@ Pattern Lab / Node wouldn't be what it is today without the support of the commu
3551

3652
## Contributing
3753

38-
### Prerequisites
39-
40-
To get started, you'll need Node 8 or higher. Managing Node with `nvm` is recommended.
41-
42-
### Testing
43-
44-
#### Unit tests
45-
46-
Unit tests are currently in `packages/core`. We use Tap
47-
48-
#### Cold start testing
49-
50-
To ensure that developers can bootstrap the repo from a fresh clone, do this in your working copy:
51-
52-
```sh
53-
git reset --hard && git clean -dfx && npm install && npm run bootstrap
54-
```
55-
56-
This ensures that any changes you've made will still result in a clean and functional developer experience. **Note**: be sure you've committed any outstanding work before doing this -- it will blow away whatever's still outstanding, including anything staged but not commited.
54+
Refer to the [contribution guidelines](https://github.com/pattern-lab/patternlab-node/blob/master/.github/CONTRIBUTING.md).

0 commit comments

Comments
 (0)