Merge pull request #18 from particle-iot/chore/sc-125805

chore: [sc-125805] Update flash-device-action to run on Node 20

Author: laupow

.github/workflows/check-dist.yml

@@ -21,12 +21,12 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
-      - name: Set Node.js 16.x
-        uses: actions/setup-node@v3.6.0
+      - name: Set Node.js 20.x
+        uses: actions/setup-node@v4
         with:
-          node-version: 16.x
+          node-version: 20.x
 
       - name: Install dependencies
         run: npm ci
@@ -45,7 +45,7 @@ jobs:
         id: diff
 
       # If index.js was different than expected, upload the expected version as an artifact
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         if: ${{ failure() && steps.diff.conclusion == 'failure' }}
         with:
           name: dist

.github/workflows/publish.yml

@@ -8,12 +8,12 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.event.release.tag_name }}
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
       - run: npm ci
       - run: npm run build
       - uses: JasonEtco/build-and-tag-action@v2

.github/workflows/test.yml

@@ -5,15 +5,15 @@ jobs:
   build: # make sure build/ci work properly
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - run: |
           npm install
       - run: |
           npm run all
 #  test: # make sure the action works on a clean machine without building
 #    runs-on: ubuntu-latest
 #    steps:
-#      - uses: actions/checkout@v3
+#      - uses: actions/checkout@v4
 #      - uses: ./
 #        with:
 #          milliseconds: 1000

.nvmrc

@@ -1 +1 @@
-v16
+20

README.md

@@ -51,7 +51,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
 
     - name: Compile firmware
       id: compile

__tests__/action.test.ts

@@ -7,6 +7,9 @@ class MockEventStream extends EventEmitter {
   constructor() {
     super()
   }
+  end(): void {
+    return
+  }
   cancel(): void {
     return
   }
@@ -118,40 +121,6 @@ describe('inputValidation', () => {
 })
 
 describe('run', () => {
-  test('errors with invalid access token', async () => {
-    process.env['INPUT_PARTICLE-ACCESS-TOKEN'] = 'invalid'
-    jest.spyOn(core, 'setFailed')
-    run()
-    expect(core.setFailed).toHaveBeenCalledWith('invalid access token')
-  })
-
-  test('errors with invalid device id', async () => {
-    process.env['INPUT_PARTICLE-ACCESS-TOKEN'] = 'a'.repeat(40)
-    process.env['INPUT_DEVICE-ID'] = 'invalid'
-    jest.spyOn(core, 'setFailed')
-    run()
-    expect(core.setFailed).toHaveBeenCalledWith('invalid device id')
-  })
-
-  test('errors with invalid timeout', async () => {
-    process.env['INPUT_PARTICLE-ACCESS-TOKEN'] = 'a'.repeat(40)
-    process.env['INPUT_DEVICE-ID'] = 'a'.repeat(24)
-    process.env['INPUT_TIMEOUT-MS'] = '-1000'
-    jest.spyOn(core, 'setFailed')
-    run()
-    expect(core.setFailed).toHaveBeenCalledWith('invalid timeout')
-  })
-
-  test('errors with invalid firmware path', async () => {
-    process.env['INPUT_PARTICLE-ACCESS-TOKEN'] = 'a'.repeat(40)
-    process.env['INPUT_DEVICE-ID'] = 'a'.repeat(24)
-    process.env['INPUT_TIMEOUT-MS'] = '1000'
-    process.env['INPUT_FIRMWARE-PATH'] = ''
-    jest.spyOn(core, 'setFailed')
-    run()
-    expect(core.setFailed).toHaveBeenCalledWith('invalid firmware path')
-  })
-
   test('test flash firmware', async () => {
     setTimeout(() => {
       mockEventStream.emit('event', {

action.yml

@@ -16,5 +16,5 @@ inputs:
     default: "300000"
     description: "Time in ms to wait for the device to come back online after flashing"
 runs:
-  using: "node16"
+  using: "node20"
   main: "dist/index.js"