fix: feedbacks

Author: coratgerl

spec/ParseUser.spec.js

@@ -82,7 +82,7 @@ describe('Parse.User testing', () => {
   });
 
   it('logs username taken with configured log level', async () => {
-    await reconfigureServer({ logEvents: { usernameAlreadyExists: 'warn' } });
+    await reconfigureServer({ logLevels: { usernameAlreadyExists: 'warn' } });
     const logger = require('../lib/logger').default;
     loggerErrorSpy = spyOn(logger, 'error').and.callThrough();
     const loggerWarnSpy = spyOn(logger, 'warn').and.callThrough();
@@ -110,7 +110,7 @@ describe('Parse.User testing', () => {
   });
 
   it('can silence username taken log event', async () => {
-    await reconfigureServer({ logEvents: { usernameAlreadyExists: 'silent' } });
+    await reconfigureServer({ logLevels: { usernameAlreadyExists: 'silent' } });
     const logger = require('../lib/logger').default;
     loggerErrorSpy = spyOn(logger, 'error').and.callThrough();
     const loggerWarnSpy = spyOn(logger, 'warn').and.callThrough();

src/Config.js

@@ -128,7 +128,6 @@ export class Config {
     requestKeywordDenylist,
     allowExpiredAuthDataToken,
     logLevels,
-    logEvents,
     rateLimit,
     databaseOptions,
     extendSessionOnUse,
@@ -171,7 +170,6 @@ export class Config {
     this.validateRequestKeywordDenylist(requestKeywordDenylist);
     this.validateRateLimit(rateLimit);
     this.validateLogLevels(logLevels);
-    this.validateLogEvents(logEvents);
     this.validateDatabaseOptions(databaseOptions);
     this.validateCustomPages(customPages);
     this.validateAllowClientClassCreation(allowClientClassCreation);
@@ -643,19 +641,6 @@ export class Config {
     }
   }
 
-  static validateLogEvents(logEvents) {
-    for (const key of Object.keys(LogLevels)) {
-      if (logEvents[key]) {
-        // We validate that each configured event uses a valid log *level* (same list as logLevels).
-        if (validLogLevels.indexOf(logEvents[key]) === -1) {
-          throw `'${key}' must be one of ${JSON.stringify(validLogLevels)}`;
-        }
-      } else {
-        logEvents[key] = LogLevels[key].default;
-      }
-    }
-  }
-
   static validateDatabaseOptions(databaseOptions) {
     if (databaseOptions == undefined) {
       return;

src/Options/Definitions.js

@@ -352,13 +352,6 @@ module.exports.ParseServerOptions = {
     action: parsers.objectParser,
     type: 'LiveQueryServerOptions',
   },
-  logEvents: {
-    env: 'PARSE_SERVER_LOG_EVENTS',
-    help: '(Optional) Overrides the log levels used by specific log events.',
-    action: parsers.objectParser,
-    type: 'LogLevels',
-    default: {},
-  },
   loggerAdapter: {
     env: 'PARSE_SERVER_LOGGER_ADAPTER',
     help: 'Adapter module for the logging sub-system',

src/Options/docs.js

@@ -98,9 +98,6 @@ export interface ParseServerOptions {
   /* (Optional) Overrides the log levels used internally by Parse Server to log events.
   :DEFAULT: {} */
   logLevels: ?LogLevels;
-  /* (Optional) Overrides the log levels used by specific log events.
-  :DEFAULT: {} */
-  logEvents: ?LogLevels;
   /* Maximum number of logs to keep. If not set, no logs will be removed. This can be a number of files or number of days. If using days, add 'd' as the suffix. (default: null) */
   maxLogFiles: ?NumberOrString;
   /* Disables console output

src/Options/index.js

@@ -467,7 +467,7 @@ export function handleParseErrors(err, req, res, next) {
       return next(err);
     }
     const usernameAlreadyExistsLevel =
-      req.config?.logEvents?.usernameAlreadyExists || 'info';
+      req.config?.logLevels?.usernameAlreadyExists || 'info';
     let httpStatus;
     // TODO: fill out this mapping
     switch (err.code) {

src/middlewares.js

@@ -47,7 +47,6 @@ export interface ParseServerOptions {
     verbose?: boolean;
     logLevel?: string;
     logLevels?: LogLevels;
-    logEvents?: LogLevels;
     maxLogFiles?: NumberOrString;
     silent?: boolean;
     databaseURI: string;