Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google auth uri spec query re: falsy strings #17

Open
SignpostMarv opened this issue May 8, 2019 · 0 comments
Open

google auth uri spec query re: falsy strings #17

SignpostMarv opened this issue May 8, 2019 · 0 comments

Comments

@SignpostMarv
Copy link
Contributor

The code for generating the qrcode message makes quick checks to see if a string is "falsy", presumably intending to check if it's empty.

This means that a $label or $issuer of '' is treated identically to '0' and ' '.

How is trailing whitespace meant to be handled in these uris- i.e. should it be simply checking '' !== $label, or trim them first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant