refactor(trie): move revealed paths tracking into SerialSparseTrie #20107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the revealed paths tracking from separate collections in
SparseStateTrie into the SerialSparseTrie struct itself.
Changes:
- Add revealed: HashSet<Nibbles> field to SerialSparseTrie
- Add revealed path methods to SparseTrieInterface trait:
- is_path_revealed: check if a path is revealed
- mark_path_revealed: mark a path as revealed
- revealed_paths: get reference to revealed paths
- revealed_paths_mut: get mutable reference to revealed paths
- Update reveal_node to automatically track and skip revealed paths
- Remove revealed_account_paths from SparseStateTrie
- Remove revealed_paths and cleared_revealed_paths from StorageTries
- Rename filter_map_revealed_nodes to map_proof_nodes
- Update clear() and wipe() to clear the revealed set
Closes paradigmxyz#14378
Himess
requested review from
Rjected,
mediocregopher and
shekhirin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
revealedpaths tracking from separate collections inSparseStateTrieinto theSerialSparseTriestruct itselfSparseTrieInterfacetrait for unified accessStorageTriesCloses #14378