Skip to content

perf: remove pending queue for MultiproofManager #19177

@yongkangc

Description

@yongkangc

Describe the feature

In previous discussions, @mattsse has mentioned that we might not even need Pending Queue as we already have crossbeam which serves as the queue.

In this PR #19171 , we realised that not having this queue might be beneficial for perf, as the pending_queue was a key bottleneck (increasing limit improved performance greatly - seen on nightly metrics as well)

Therefore we should explore remove pending queue and is_full() from MultiProofManager

We do have to keep in mind possible perf regression from https://github.com/paradigmxyz/reth/pull/18727/files which introduced chunking only when queue is full

Additional context

No response

Metadata

Metadata

Assignees

Labels

A-engineRelated to the engine implementationC-debtA clean up/refactor of existing codeC-enhancementNew feature or requestC-perfA change motivated by improving speed, memory usage or disk footprintS-needs-benchmarkThis set of changes needs performance benchmarking to double-check that they help

Type

No type

Projects

Status

Completed

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions