-
Notifications
You must be signed in to change notification settings - Fork 135
Capturing window is broken in screenshot view caused by a js error #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can confirm this issue on Gnome 46. I think on Gnome 45 it still worked some time ago (but not 100% sure). The behavior is also a bit inconsistent. From very limited testing:
It seems like @jtaala does this have something to do with what you implemented for the gnome overview? If so can you take a look here? Otherwise I will try to look into it. |
Sure, just pushed up a fix for that comparator. Can you please test branch fix-gnome-window-screenshot? |
Yes it fixes the problem. |
Well, it's fixed in that the windows show, but it's also showing PaperWM's clipping for partially shown windows: A workaround this by going into Gnome Both of those options are some work, I'll push up this fix first anyways and keep this issue open. |
Just a heads-up that I'm going to try fix the clipping issue tonight (will experiment with hiding the |
Morning all, I believe I've now fixed the clipping windows issue. @lost-melody, could you please pull the latest on fix-gnome-window-screenshot and test? I've added a patch to remove window clipping (which clips windows to the monitor boundaries in PaperWM) when the |
@jtaala, I've tried your fix and it works, but a side effect is introduced. If I return to Overview from ScreenshotUI (by pressing |
Nice pickup @lost-melody. Fixed. |
Most of these issues are due to the gnome paradigm of "one workspace across all monitors" (i.e. see #389 (comment)). Even with multiple monitors, on vanilla gnome it's actually one workspace. That's what's happening here, for screenshots, gnome is pulling the windows on that "workspace" (which conflicts with PaperWM approach of having one workspace per monitor). Anyways, what it means is that for screenshotting windows with PaperWM (and multiple monitors), is that pressing printscreen will show the windows on that PaperWM space... which may be spread out across multiple monitors (in the case where some windows are to the left/right in scrolling space. It's workable, but may be confusing. |
Describe the bug
As a GNOME feature, we can press
PrtSc
to take a screenshot, and in the "screenshot view" we can then pressw
to preview and select a window to capture.Now when I try to capture a window, there's no preview displayed and no window to select. Plus an error is observed in logs. (see addition context)
To Reproduce
Steps to reproduce the behavior:
PrtSc
(or whatever keybinding for Take a screenshot interactively in GNOME keyboard shortcuts settings).w
if not in window selection view.Expected behavior
Previews of windows should be listed to select and capture.
Screenshots
Nothing displayed
Expected
System information:
System information
Additional context
Error logs
A workaround is to add those codes in function
sortWindows
:This is not a fix, but I cannot proceed any further.
The text was updated successfully, but these errors were encountered: