Skip to content

Cannot perform touch events on non-focused monitor #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Thesola10 opened this issue Oct 28, 2023 · 7 comments · Fixed by #660 or #759
Closed

Cannot perform touch events on non-focused monitor #655

Thesola10 opened this issue Oct 28, 2023 · 7 comments · Fixed by #660 or #759
Labels
bug Undesirable behavior multi-monitors Issue specific to multi-monitor setup regression Previously fixed, but occured again. touchscreen Issue is related to touch screen functionality

Comments

@Thesola10
Copy link
Collaborator

Describe the bug
GNOME is capable of handling multiple monitors, each with their own touch surface. When PaperWM is active, touch screen events are discarded for all apps on displays other than the currently focused one, and I need to move the mouse to the other display to use the touch screen on it.

To Reproduce
Steps to reproduce the behavior:

  1. Connect two touch capable displays
  2. Open windows on both displays with PaperWM active
  3. Move the mouse to one display
  4. Try to touch the other display
  5. Nothing happens

Expected behavior
The other window reacts properly to touch events

System information:

Distribution: Arch Linux
GNOME Shell 45.0
Display server: Wayland
PaperWM branch/tag: develop
PaperWM commit: c0ce6ab65bbf72bfc59579eb24a119060d68b581
Enabled extensions:
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- quick-settings-tweaks@qwreey
- [email protected]
- quick-settings-avatar@d-go
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]

Additional context
Native GNOME without PaperWM lets touch events through to unfocused monitors.
@Thesola10 Thesola10 added the bug Undesirable behavior label Oct 28, 2023
@Thesola10
Copy link
Collaborator Author

This might also occur with a single touch monitor and a non-touch monitor, if the mouse is in the non-touch monitor.

@jtaala
Copy link
Collaborator

jtaala commented Oct 28, 2023 •
edited
Loading

This is likely because of the StackOverlay actor that gets enabled on monitors where the mouse isn't.

See this thread where I talk a bit about this peterfajdiga/karousel#3

It's basically how we do a "per monitor workspace".

@jtaala
Copy link
Collaborator

jtaala commented Oct 28, 2023

Uncomment these lines to see the overlay (that's most likely blocking your touch events):

https://github.com/paperwm/PaperWM/blob/release/stackoverlay.js#L282-L283

@Thesola10
Copy link
Collaborator Author

Thesola10 commented Oct 30, 2023 •
edited
Loading

So basically, hooking StackOverlay's TOUCH_BEGIN to "switch monitors as if the mouse entered it" could work?

This would also mean, check that if the mouse starts moving again on a monitor that was defocused by a touch event, the switch triggers again properly

@jtaala
Copy link
Collaborator

jtaala commented Oct 30, 2023

In principle yes - making stackoverlay reactive to touch should cause that monitor space to select (make it active).

Also, yes, the mouse movement should trigger the mouse-monitor to become active.

@Thesola10 Thesola10 added the multi-monitors Issue specific to multi-monitor setup label Oct 30, 2023
This was referenced Nov 1, 2023
Closed
Merged
@Thesola10 Thesola10 linked a pull request Nov 1, 2023 that will close this issue
Added touch support to multi-monitor switching #660
Merged
@Thesola10 Thesola10 mentioned this issue Jan 22, 2024
Draft
@Thesola10 Thesola10 reopened this Jan 22, 2024
@Thesola10
Copy link
Collaborator Author

hm, regression seems to have happened at some point during #751 merge, or I did not test focus behavior properly.

@Thesola10 Thesola10 mentioned this issue Jan 22, 2024
Merged
@Thesola10
Copy link
Collaborator Author

Thesola10 commented Jan 26, 2024 •
edited
Loading

Closed (again, hopefully for good 😅) by #759

@Thesola10 Thesola10 added regression Previously fixed, but occured again. touchscreen Issue is related to touch screen functionality labels Jan 26, 2024
@Thesola10 Thesola10 linked a pull request Jan 30, 2024 that will close this issue
Fix regression touchscreen support #759
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Undesirable behavior multi-monitors Issue specific to multi-monitor setup regression Previously fixed, but occured again. touchscreen Issue is related to touch screen functionality
Projects
None yet
Milestone
No milestone
2 participants
@Thesola10 @jtaala