Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect equivalent latitude calculation #2

Open
kuchaale opened this issue Nov 25, 2021 · 4 comments
Open

Incorrect equivalent latitude calculation #2

kuchaale opened this issue Nov 25, 2021 · 4 comments

Comments

@kuchaale
Copy link

kuchaale commented Nov 25, 2021

Hi @pankajkarman, thanks for the pyvortex module - very helpful. However, I may have found a bug in the equivalent latitude calculation. See my gist here. Therein I use PV and ZW from ERA-Interim at 600 K and two different time steps (2008-12-03T12, 2009-01-05T00). The equivalent latitude is incorrect for the latter time step. Once I modify _eqvlat after hn2016_falwa.basis.eqvlat and consequently get_edge, I produce more reasonable results. Looking forward to your response.

@pankajkarman
Copy link
Owner

Hi @kuchaale, Thank you very much for your interest in this package and I am glad you found it useful. Your concern is quite valid. The issue seems to arise from the formula used for calculation of equivalent latitude used. While pyvortex uses equation from Anel et al. for estimation of EqL i.e.

allen2

hn2016_falwa.basis.eqvlat uses equation from Allen et al. for the same.

allen1

While these seemed to be working ok till now, but if this issue is indeed due to the equation mentioned above, I'll change it to align with correct result. Can please check and confirm?

@kuchaale
Copy link
Author

kuchaale commented Nov 26, 2021

You're right. Anel et al. actually used the formula from Lary et al. (see eq. 4 in the appendix). They even provide their IDL codes here. Maybe @eqlat can explain the formula difference?

@JAAxel
Copy link

JAAxel commented Dec 2, 2021

Hi everyone,
Thanks @kuchaale for letting me know about this issue. I have taken a quick look into the bug report, but I have no time today to check if this is an issue with pyvortex or our original code.
Could you provide more detail about where you think that is the bug? Cause?
I do not know if it is the case here, but I recall subtle differences between the original Lary et al. and the posterior version by Douglas Allen.

By the way, nice to see that you are using this. If you have based your routines or computation on the ideas or software in our paper, please, cite it. This is encouraging, lets us know about the community using it, and helps us secure funding for our research work.

@kuchaale
Copy link
Author

kuchaale commented Dec 2, 2021

Hi @JAAxel, the issue is related to pyvortex. Your paper is mentioned as a reference for one way how to calculate the equivalent latitude. References quite differ on this matter. Additionally, Nakamura (1995) and Norton (1994) formulate the equivalent latitude in agreement with Lary et al and Anel et al (see Eqs. 2.11 and A1, respectively). The formulas are just inverse to each other but apparently, it matters.

Your IDL routines may be useful but internal IDL functions such as ComputeGeometry and contour require IDL license, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants