Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continuous integration and testing #10

Open
aaronspring opened this issue Aug 5, 2021 · 4 comments
Open

continuous integration and testing #10

aaronspring opened this issue Aug 5, 2021 · 4 comments

Comments

@aaronspring
Copy link
Contributor

great package. I am wrapping it in https://github.com/pangeo-data/climpred/blob/355f849d19838085705c89d7b912b0e2fae89f07/climpred/bias_removal.py#L492 and it will help us bias correcting precip forecasts.

Is there a way to test bias_correction (in a continuous integration sense)?

  • what/how: Making some demo fake data with different distributions and then running bias_correction on it and see how whether the results are as expected
  • why: stability of the package, implement new features without breaking the rest, ...
@aaronspring
Copy link
Contributor Author

@PauRiv

@pankajkarman
Copy link
Owner

I have been thinking about implementing some test cases to ensure the robustness of the package. However, I am not sure about how to do it. May be take data from papers already using or proposing the methods implemented here.

@aaronspring
Copy link
Contributor Author

aaronspring commented Aug 8, 2021

couldnt we create a normal distribution for observations, add some skew or mean shift to get observations and then test that after bias reduction the method='normal_mapping/basic_quantile/modified_quantile' bias-reduced forecasts are on a straight line with observations?

no clue what to do with gamma_mapping

@pankajkarman
Copy link
Owner

yeah. That's good one. We have to think over the ways to test gamma mapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants