From b74bde00cdc70fdb6f6eef9592528ba4bc00efd4 Mon Sep 17 00:00:00 2001 From: Harald Sitter Date: Tue, 7 Sep 2021 14:54:44 +0200 Subject: [PATCH] Revert "cleanup after asgen" This reverts commit c8a4f87f805db4497a80dd7ddabb6a9bf9c7a8ab. https://github.com/ximion/appstream-generator/issues/97 --- nci/asgen.rb | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/nci/asgen.rb b/nci/asgen.rb index 7553d2142..fe26b21ca 100755 --- a/nci/asgen.rb +++ b/nci/asgen.rb @@ -1,7 +1,7 @@ #!/usr/bin/env ruby # frozen_string_literal: true # -# Copyright (C) 2016-2021 Harald Sitter +# Copyright (C) 2016-2019 Harald Sitter # # This library is free software; you can redistribute it and/or # modify it under the terms of the GNU Lesser General Public @@ -90,7 +90,13 @@ FileUtils.mkpath(run_dir) unless Dir.exist?(run_dir) config.write("#{run_dir}/asgen-config.json") suites.each do |suite| - cmd.run('appstream-generator', 'process', '--verbose', suite, chdir: run_dir)#, + cmd.run("appstream-generator", 'process', '--verbose', suite, chdir: run_dir)#, # env: { http_proxy: NCI::PROXY_URI, https_proxy: NCI::PROXY_URI }) - cmd.run('appstream-generator', 'cleanup', chdir: run_dir) # clean up cruft end + +# TODO +# [15:03] sitter: the version number changing isn't an issue - +# it does nothing with one architecture, and it's an optimization if you have +# at least one other architecture. +# [15:03] sitter: you should run ascli cleanup every once in a while +# though, to collect garbage