Skip to content

STY: Enforce Ruff rule B905, zip-without-explicit-strict #62434

@mroeschke

Description

@mroeschke

zip calls should ideally specify strict=True since most of the time there's an underlying assumption that the input arguments are of equal length. To enforce this we should enable the Ruff rule zip-without-explicit-strict, https://docs.astral.sh/ruff/rules/zip-without-explicit-strict/

Since there are about ~500 occurrences of zip in the code base, this issue should be completed in multiple PRs that adds strict=True to zip calls in a particular directory. Therefore, this issue can be worked on by multiple contributors.

For those interested in working on this issue:

  1. Comment below on which directory you'll be working on. If you want to work on pandas/core, please choose a subdirectory in this location e.g. pandas/core/internals
  2. Submit a PR adding strict=True (or strict=False if necessary) to zip calls

Once all zip calls are have a strict argument, a separate PR will be needed to move "B905" from the ignore section to the select section.

"B905",

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions