use strict typing for tslibs/nattype and tslibs/dtypes #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
strict-tslibs-2
branch
from
5cb8444 to
dcf9ddb
Compare
MarcoGorelli
commented
Mar 10, 2025
Dr-Irv
reviewed
Mar 10, 2025
|
thanks for your review I checked and everything in pandas-stubs/_libs/tslibs/dtypes.pyi is either undocumented or unused (https://github.com/pandas-dev/pandas/pull/46338/files removed quite a few things), so I've just removed the file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value