make tslibs strptime, timedeltas, and timestamps pass with pyright-strict

[MarcoGorelli]

towards #1133

• Closes #xxxx (Replace xxxx with the Github issue number)
• Tests added: Please use assert_type() to assert the type of any return value

[Dr-Irv]

I think the references that you made Index[Timestamp] should be DatetimeIndex . We don't have Index[Timestamp] in the stubs.

You also should be adding UnknownIndex because someone could do something like this:

df = pd.DataFrame([[ (some data here) ]], names=['timedata', 'otherdata'])
df = df.set_index('timedata')

Then df.index will be unknown - we can't track the type, but you might pass it to some of those methods where we used the Index type

[MarcoGorelli]

thanks for your review!

Then df.index will be unknown - we can't track the type, but you might pass it to some of those methods where we used the Index type

Yup - in that case, the inner type will be ignored. I've added a test for this anyway 👍

[MarcoGorelli]

🤔 not sure what to make of the CI failure - we get /home/runner/work/pandas-stubs/pandas-stubs/pandas-stubs/_libs/tslibs/timestamps.pyi:19:21 - error: Type of "TimeZones" is unknown (reportUnknownVariableType) but only on 3.11

I've removed the # pyright: strict from timestamps.pyi for now, that fixes it

[Dr-Irv]

You'll have to let me know when you're good with this, given that the goal was to make strict work in both PYI files

[Dr-Irv]

So in the other PR for StringMethods, I changed DataFrame.__getitem__() to return UnknownSeries, which allows matching it in an overload.

So here, I think if you change DataFrame.index to be UnknownIndex and use UnknownIndex instead of Index[Any] things would work. Just a hunch.

[MarcoGorelli]

ok thanks, i'll resume this when UnknownIndex and UnknownSeries are available

[MarcoGorelli]

still can't get Python3.11 to pass in CI

  /home/runner/work/pandas-stubs/pandas-stubs/pandas-stubs/_libs/tslibs/timestamps.pyi:20:21 - error: Type of "TimeZones" is unknown (reportUnknownVariableType)
  /home/runner/work/pandas-stubs/pandas-stubs/pandas-stubs/_libs/tslibs/timestamps.pyi:76:9 - error: Type of parameter "tz" is unknown (reportUnknownParameterType)
  /home/runner/work/pandas-stubs/pandas-stubs/pandas-stubs/_libs/tslibs/timestamps.pyi:272:26 - error: Type of parameter "tz" is unknown (reportUnknownParameterType)
  /home/runner/work/pandas-stubs/pandas-stubs/pandas-stubs/_libs/tslibs/timestamps.pyi:276:9 - error: Type of parameter "tz" is unknown (reportUnknownParameterType)

which I find bizarre because locally it passes for me even on 3.11 🤔

[Dr-Irv]

which I find bizarre because locally it passes for me even on 3.11 🤔

And it worked fine on Windows in CI.

I got it to work by taking the import of TimeZones out of timestamps.pyi and copying it from _typing.pyi into timestamps.pyi and then it got past the CI. Not ideal.

So I am guessing that because timestamps.pyi is set up to be strict, but _typing.pyi i not, that is why it got confused.

But why that only happens on 3.11 on Mac and Ubuntu is really odd.

[Dr-Irv]

looks like we are getting closer. I suggested a few extra tests and some other cleanup.

[Dr-Irv]

Thanks @MarcoGorelli