Include instance ID in remote exception message (#46)

Author: meditativeape

errors/src/main/java/com/palantir/remoting/api/errors/RemoteException.java

@@ -37,8 +37,9 @@ public int getStatus() {
 
     public RemoteException(SerializableError error, int status) {
         super(error.errorCode().equals(error.errorName())
-                ? String.format("RemoteException: %s", error.errorCode())
-                : String.format("RemoteException: %s (%s)", error.errorCode(), error.errorName()));
+                ? String.format("RemoteException: %s with instance ID %s", error.errorCode(), error.errorInstanceId())
+                : String.format("RemoteException: %s (%s) with instance ID %s",
+                        error.errorCode(), error.errorName(), error.errorInstanceId()));
 
         this.error = error;
         this.status = status;

errors/src/test/java/com/palantir/remoting/api/errors/RemoteExceptionTest.java

@@ -52,13 +52,15 @@ public void testSuperMessage() {
                 .errorName("errorName")
                 .errorInstanceId("errorId")
                 .build();
-        assertThat(new RemoteException(error, 500).getMessage()).isEqualTo("RemoteException: errorCode (errorName)");
+        assertThat(new RemoteException(error, 500).getMessage())
+                .isEqualTo("RemoteException: errorCode (errorName) with instance ID errorId");
 
         error = new SerializableError.Builder()
                 .errorCode("errorCode")
                 .errorName("errorCode")
                 .errorInstanceId("errorId")
                 .build();
-        assertThat(new RemoteException(error, 500).getMessage()).isEqualTo("RemoteException: errorCode");
+        assertThat(new RemoteException(error, 500).getMessage())
+                .isEqualTo("RemoteException: errorCode with instance ID errorId");
     }
 }