Change SerializableError json name from errorId to errorInstanceId

Author: Robert Fink

errors/src/main/java/com/palantir/remoting/api/errors/SerializableError.java

@@ -65,7 +65,7 @@ public String errorName() {
      * #errorName}, the {@link #errorInstanceId} identifies a specific occurrence of an error, not a class of errors. By
      * convention, this field is a UUID.
      */
-    @JsonProperty("errorId")
+    @JsonProperty("errorInstanceId")
     @Value.Default
     @SuppressWarnings("checkstyle:designforextension")
     public String errorInstanceId() {

errors/src/test/java/com/palantir/remoting/api/errors/SerializableErrorTest.java

@@ -51,13 +51,13 @@ public void testExceptionToError() {
     @Test
     public void testSerializationContainsRedundantParameters() throws Exception {
         assertThat(mapper.writeValueAsString(ERROR))
-                .isEqualTo("{\"errorCode\":\"code\",\"errorName\":\"name\",\"errorId\":\"\",\"parameters\":{},"
+                .isEqualTo("{\"errorCode\":\"code\",\"errorName\":\"name\",\"errorInstanceId\":\"\",\"parameters\":{},"
                         + "\"exceptionClass\":\"code\",\"message\":\"name\"}");
 
         assertThat(mapper.writeValueAsString(
                 SerializableError.builder().from(ERROR).errorInstanceId("errorId").build()))
-                .isEqualTo("{\"errorCode\":\"code\",\"errorName\":\"name\",\"errorId\":\"errorId\",\"parameters\":{},"
-                        + "\"exceptionClass\":\"code\",\"message\":\"name\"}");
+                .isEqualTo("{\"errorCode\":\"code\",\"errorName\":\"name\",\"errorInstanceId\":\"errorId\""
+                        + ",\"parameters\":{},\"exceptionClass\":\"code\",\"message\":\"name\"}");
     }
 
     @Test
@@ -69,7 +69,7 @@ public void testDeserializesWhenRedundantParamerersAreGiven() throws Exception {
 
     @Test
     public void testDeserializesWhenExplicitErrorIdIsGiven() throws Exception {
-        String serialized = "{\"errorCode\":\"code\",\"errorName\":\"name\",\"errorId\":\"errorId\"}";
+        String serialized = "{\"errorCode\":\"code\",\"errorName\":\"name\",\"errorInstanceId\":\"errorId\"}";
         assertThat(deserialize(serialized))
                 .isEqualTo(SerializableError.builder().from(ERROR).errorInstanceId("errorId").build());
     }