Make UnknownRemoteError safe-loggable (#374)

Author: gatesn

changelog/@unreleased/pr-374.v2.yml

@@ -0,0 +1,5 @@
+type: improvement
+improvement:
+  description: Make UnknownRemoteException safe-loggable
+  links:
+  - https://github.com/palantir/conjure-java-runtime-api/pull/374

errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java

@@ -16,10 +16,16 @@
 
 package com.palantir.conjure.java.api.errors;
 
+import com.palantir.logsafe.Arg;
+import com.palantir.logsafe.SafeArg;
+import com.palantir.logsafe.SafeLoggable;
+import java.util.Collections;
+import java.util.List;
+
 /**
  * An exception thrown by an RPC client to indicate remote/server-side failure from a non-remoting server.
  */
-public final class UnknownRemoteException extends RuntimeException {
+public final class UnknownRemoteException extends RuntimeException implements SafeLoggable {
     private static final long serialVersionUID = 1L;
 
     private final int status;
@@ -41,4 +47,14 @@ public UnknownRemoteException(int status, String body) {
         this.body = body;
     }
 
+    @Override
+    public String getLogMessage() {
+        return "Failed to parse response body as SerializableError.";
+    }
+
+    @Override
+    public List<Arg<?>> getArgs() {
+        return Collections.singletonList(SafeArg.of("status", getStatus()));
+    }
+
 }

errors/src/test/java/com/palantir/conjure/java/api/errors/UnknownRemoteExceptionTest.java

@@ -0,0 +1,41 @@
+/*
+ * (c) Copyright 2019 Palantir Technologies Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.palantir.conjure.java.api.errors;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import com.palantir.logsafe.SafeArg;
+import org.junit.jupiter.api.Test;
+
+class UnknownRemoteExceptionTest {
+
+    @Test
+    public void testMessage() {
+        UnknownRemoteException exception = new UnknownRemoteException(404, "not found");
+        assertThat(exception.getMessage())
+                .isEqualTo("Error 404. (Failed to parse response body as SerializableError.)");
+        assertThat(exception.getLogMessage())
+                .isEqualTo("Failed to parse response body as SerializableError.");
+    }
+
+    @Test
+    public void testArgsContainsStatus() {
+        UnknownRemoteException exception = new UnknownRemoteException(404, "not found");
+        assertThat(exception.getArgs()).containsOnly(SafeArg.of("status", 404));
+    }
+
+}