Remove redundant formatting code in ServiceException (#15)

Robert Fink · web-flow · commit 9d5d67414e58 · 2017-07-17T18:36:56.000-07:00
diff --git a/errors/src/main/java/com/palantir/remoting/api/errors/ServiceException.java b/errors/src/main/java/com/palantir/remoting/api/errors/ServiceException.java
@@ -105,9 +105,7 @@ private static String renderSafeMessage(ErrorType errorType, List<Arg<?>> args)
     }
 
     private static String renderNoArgsMessage(ErrorType errorType) {
-        return errorType.code().name().equals(errorType.name())
-                ? String.format("ServiceException: %s", errorType.code())
-                : String.format("ServiceException: %s (%s)", errorType.code(), errorType.name());
+        return String.format("ServiceException: %s (%s)", errorType.code(), errorType.name());
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -105,9 +105,7 @@ private static String renderSafeMessage(ErrorType errorType, List<Arg<?>> args)`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`private static String renderNoArgsMessage(ErrorType errorType) {`
`108`		`- return errorType.code().name().equals(errorType.name())`
`109`		`- ? String.format("ServiceException: %s", errorType.code())`
`110`		`- : String.format("ServiceException: %s (%s)", errorType.code(), errorType.name());`
	`108`	`+ return String.format("ServiceException: %s (%s)", errorType.code(), errorType.name());`
`111`	`109`	`}`
`112`	`110`
`113`	`111`	`@Override`